[issue1222] locale.format bug if thousand separator is space (french separator as example)

Eric Smith added the comment: Antoine Pitrou wrote: > The problem seems to be that the thousands separator on the Solaris > variant of en_US is an empty string (rather than a comma) (*), and > apparently it hits a bug in the padding mechanism (which perhaps assumes > that the thousands separator

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Mark Dickinson added the comment: It looks like that did the trick. Thank you! -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Antoine Pitrou added the comment: Trying a fix in r70458. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Antoine Pitrou added the comment: By the way, Martin, do you have any idea why the Solaris buildbot doesn't seem to be enabled on trunk? -- ___ Python tracker ___ ___

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Antoine Pitrou added the comment: Hi Mark, > AssertionError: ' 4200' != ' 4200' > > Any idea what's going on here? The problem seems to be that the thousands separator on the Solaris variant of en_US is an empty string (rather than a comma) (*), and apparently it hits a bug in the pa

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Mark Dickinson added the comment: r70357 seems to have caused the sparc solaris py3k buildbot to start failing on test_locale: == FAIL: test_integer_grouping_and_padding (test.test_locale.TestNumberFormatting) ---

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Antoine Pitrou added the comment: Committed in r70356, r70357, r70358, r70359. I didn't try to change anything about the trailing space since it's minor anyway. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Walter Doekes <[EMAIL PROTECTED]> added the comment: @Antoine Pitrou Regarding "# XXX is the trailing space a bug?": I'm inclined to believe that it is. Man 7 locale does not mention that p_sep_by_space should be used for non-int currency symbols, nor that it shouldn't. However, it does say: ""

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Changes by Walter Doekes <[EMAIL PROTECTED]>: -- nosy: +wdoekes ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailing

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Changes by Antoine Pitrou <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file10041/1222.patch ___ Python tracker <[EMAIL PROTECTED]> ___

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Changes by Antoine Pitrou <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file10128/bug1222.patch ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Here is the patch for the third part. Added file: http://bugs.python.org/file10984/thousands_sep.patch ___ Python tracker <[EMAIL PROTECTED]>

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: The first 2 parts have been committed in r65237. I'll soon provide a patch for the third part. ___ Python tracker <[EMAIL PROTECTED]> _

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Eric Smith <[EMAIL PROTECTED]> added the comment: I'd recommend breaking the patch into the 3 parts mentioned in msg61929, then committing the first 2 parts. That should make the 3rd part much easier to evaluate. ___ Python tracker <[EMAIL PROTECTED]>

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Would someone object to committing this before beta3? For clarity I would first commit the rewrite of test_locale to use unittest, and then the fix for the thousands separator bug. -- priority: -> normal

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Ok, here is an updated patch for Windows compatibility of the test suite. Added file: http://bugs.python.org/file10128/bug1222.patch __ Tracker <[EMAIL PROTECTED]> __

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: I've had the opportunity to test on a Windows box and there are various failures in the TestStringMethods test case. If someone with more knowledge of the Windows world could take a lookm it would be nice. __ T

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Changes by Eric Smith <[EMAIL PROTECTED]>: -- nosy: +eric.smith __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe:

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: I see that http://wiki.python.org/moin/PythonBugDay says "need to test on non-MacOS platform". Actually, I've tested the patch under Mandriva and Debian Linux. __ Tracker <[EMAIL PROTECTED]>

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Here is an updated patch against trunk. -- keywords: +patch Added file: http://bugs.python.org/file10041/1222.patch __ Tracker <[EMAIL PROTECTED]> ___

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Changes by Antoine Pitrou <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file9341/1222.patch __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bug

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Georg Brandl added the comment: Looks good to me. __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Antoine Pitrou added the comment: Here is a patch. It is fairly big and I'm sorry about it, here is why: 1. it reworks the test suite using unittest, and makes it more comprehensive 2. it adds a feature in locale.py which allows overriding the localeconv dictionary (this is necessary for proper t

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Georg Brandl added the comment: The space removal was there before my change; assigning to Martin. -- assignee: -> loewis __ Tracker <[EMAIL PROTECTED]> __ ___

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Antoine Pitrou added the comment: Eric, your diagnostic looks right, format() gets confused when it tries to remove padding characters to account for the added thousands separators. It does not check that there were padding characters in the first place, and it assumes that the thousands separato

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Changes by Antoine Pitrou: -- versions: +Python 2.6 -Python 2.4 __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Antoine Pitrou added the comment: Ok, I manage to reproduce it on an Ubuntu box with both 2.5.2a0 and SVN trunk. IMO it's a bug since the expected behaviour would be to enforce the locale settings for number formatting. That's the whole purpose of locale.format() after all. (no to mention the dis

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Antoine Pitrou added the comment: Just tried on 2.5.1 and on trunk, I can't reproduce it. On both I get: >>> import locale >>> locale.setlocale(locale.LC_NUMERIC, "fr_FR.UTF-8") 'fr_FR.UTF-8' >>> locale.format("%9.2f", 12345.67, True) ' 12345,67' >>> locale.format("%.2f", 12345.67, True) '12345,

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Changes by Dave Hughes: -- nosy: +waveform __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue1222] locale.format bug if thousand separator is space (french separator as example)

New submission from de la Musse: locale.format function delete spaces in result which is a problem when thousand separator is space (in French for example). The problem seems in the code below (extract from locale.py): 145 while seps: 146 # If the number was formatted for a specific

[issue1222] locale.format bug if thousand separator is space (french separator as example)

Changes by de la Musse: -- components: Library (Lib) severity: normal status: open title: locale.format bug if thousand separator is space (french separator as example) type: behavior versions: Python 2.4 __ Tracker <[EMAIL PROTECTED]>