[issue12263] punycode codec ignores the error handler argument

STINNER Victor added the comment: I prefer to not touch punycode right now, it works, there is no need to modify it. -- resolution: -> wont fix status: open -> closed ___ Python tracker __

[issue12263] punycode codec ignores the error handler argument

Martin v. Löwis added the comment: > Oh, I forgot to give a little bit more details. > > b'abc\xff-'.decode('punycode', 'ignore') and > b'abc\xff-'.decode('punycode', 'replace') raise a UnicodeDecodeError: > the error handler is just useless (ignored) here. That's not my point: b"foo".decode(

[issue12263] punycode codec ignores the error handler argument

STINNER Victor added the comment: Oh, I forgot to give a little bit more details. b'abc\xff-'.decode('punycode', 'ignore') and b'abc\xff-'.decode('punycode', 'replace') raise a UnicodeDecodeError: the error handler is just useless (ignored) here. With my patch, b'abc\xff-'.decode('punycode',

[issue12263] punycode codec ignores the error handler argument

Martin v. Löwis added the comment: What's the point of disallowing the replace error handler? That's a slightly incompatible change, isn't it? -- ___ Python tracker ___ ___

[issue12263] punycode codec ignores the error handler argument

STINNER Victor added the comment: @Martin: Can you review my patch? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue12263] punycode codec ignores the error handler argument

STINNER Victor added the comment: punycode_errors.patch: - raise an error if errors="replace": only accept strict and ignore - use errors to encode/decode to/from ASCII - add unit tests I don't think that the change should be documented, because punycode has no section in Doc/library/codecs

[issue12263] punycode codec ignores the error handler argument

Changes by R. David Murray : -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue12263] punycode codec ignores the error handler argument

STINNER Victor added the comment: base64_codec.py uses an assertion to check the error handler: it should use an if+raise (assertions are ignored in optimized mode, python -O). -- ___ Python tracker _

[issue12263] punycode codec ignores the error handler argument

New submission from STINNER Victor : b'abc\xff'.decode('punycode', 'ignore') raises the same error than b'abc\xff'.decode('punycode', 'replace') or b'abc\xff'.decode('punycode'): it uses the strict error handler, and simply ignores the error handler. punycodec, as idna, should raise an excepti