[issue12338] multiprocessing.util._eintr_retry doen't recalculate timeouts

Richard Oudkerk added the comment: _eintr_retry was removed by 99ef4501205b. -- resolution: -> out of date stage: -> committed/rejected status: open -> closed type: -> behavior ___ Python tracker __

[issue12338] multiprocessing.util._eintr_retry doen't recalculate timeouts

Antoine Pitrou added the comment: Note that socketserver's timeout is not really important: it's just used for a polling loop, with a default of 0.5 seconds. -- ___ Python tracker

[issue12338] multiprocessing.util._eintr_retry doen't recalculate timeouts

STINNER Victor added the comment: > SocketServer has been changed to restart select() on EINTR, > but it doesn't recompute the timeout. See issue #7978. -- ___ Python tracker _

[issue12338] multiprocessing.util._eintr_retry doen't recalculate timeouts

STINNER Victor added the comment: SocketServer has been changed to restart select() on EINTR, but it doesn't recompute the timeout. -- ___ Python tracker ___ __

[issue12338] multiprocessing.util._eintr_retry doen't recalculate timeouts

Antoine Pitrou added the comment: > _eintr_retry is currently unused. AFAICT it's still used in forking.py. -- versions: +Python 3.3 ___ Python tracker ___

[issue12338] multiprocessing.util._eintr_retry doen't recalculate timeouts

sbt added the comment: _eintr_retry is currently unused. The attached patch removes it. If it is retained then we should at least add a warning that it does not recalculate timeouts. -- keywords: +patch Added file: http://bugs.python.org/file24888/mp_remove_eintr_retry.patch ___

[issue12338] multiprocessing.util._eintr_retry doen't recalculate timeouts

STINNER Victor added the comment: subprocess._communicate_with_select() retries select.select() on EINTR: it recomputes timeout before each call. while self._read_set or self._write_set: timeout = self._remaining_time(endtime) if timeout is not None and timeout < 0: raise Timeo

[issue12338] multiprocessing.util._eintr_retry doen't recalculate timeouts

Changes by STINNER Victor : -- nosy: +haypo, pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue12338] multiprocessing.util._eintr_retry doen't recalculate timeouts

New submission from sbt : multiprocessing.util._eintr_retry is only used to wrap select.select, but it fails to recalculate timeouts. Also, it will never retry the function it wraps because of a missing "import errno". I think it would be better to just implement the retrying version of selec