[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks

Senthil Kumaran added the comment: Thanks for the notification. Seems I over looked it. Fixed it with the changes in 76212 (trunk) and 76213 (release26-maint). py3k did not have this issue. -- ___ Python tracker __

[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks

Brian Curtin added the comment: This change causes failures in test_httpservers on trunk r76211 on Windows. I attached a simple patch which fixes the problem (NameError on 'p'). -- nosy: +brian.curtin Added file: http://bugs.python.org/file15309/issue1235_fix.patch

[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks

Senthil Kumaran added the comment: Committed revision 76209 - release26-maint Committed revision 76210 - py3k Committed revision 76211 - release31-maint Thanks Derk for the patch. -- resolution: -> fixed status: open -> closed ___ Python tracker <

[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks

Senthil Kumaran added the comment: Committed revision 76208 in trunk. Shall look at the output of windows buildbots and merge the changes to other codelines. -- ___ Python tracker _

[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks

Changes by Derk Drukker : Removed file: http://bugs.python.org/file15181/fix-issue1235-py3k.patch ___ Python tracker ___ ___ Python-bugs-list m

[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks

Derk Drukker added the comment: orsenthil: I reverted the changes that make Windows and Unix use the same code in Patch Set 3, and briefly mentioned the reason for that in the Rietveld app. I should have mentioned it here too. It was because it actually makes the implementation on Unix worse,

[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks

Senthil Kumaran added the comment: drukker: I verified your patch. Looks fine for changes made to the subprocess call. You mentioned: I've also unified the Unix and Windows portions in run_cgi. Both now use subprocess." I don't see it in the patch. Was it that you assumed changing the variabl

[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks

Derk Drukker added the comment: More elegant than using quotes in the cmdline string is, IMO, passing a sequence to subprocess.Popen instead. I've put a new patch up for review: http://codereview.appspot.com/141050 I've also unified the Unix and Windows portions in run_cgi. Both now use subpr

[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks

Changes by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks

Changes by Stac : Removed file: http://bugs.python.org/file15175/MyCGIHTTPServer.py ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks

Derk Drukker added the comment: The original problem reported concerned spaces in the path of the python executable. So interp needs to be in quotes, as well (as Andy already suggested). I've created a patch against the latest py3k, which I've confirmed works and fixes this issue. I'm not a c

[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks

Stac added the comment: Ok, I corrected the two versions. Now the one for py2.x is closer to the fix for py3k. You'll find below the fixed code for both version. Regards, Stac -- Added file: http://bugs.python.org/file15180/fix.tar ___ Python trac

[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks

Stac added the comment: Oups, I really feel sorry. Well here is a version with the modified cmdline. I will check how the migration was done in py3k. Just a quick question : why the changes done in py3k was not reported to py2.x ? Regards, Stac -- Added file: http://bugs.python.org

[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks

Derk Drukker added the comment: Salut, Note that in py3k, CGIHTTPRequestHandler (Lib/http/server.py) already switched to using subprocess. AFAICT, you didn't actually change cmdline, and so the problem remains. -- nosy: +drukker versions: +Python 3.1, Python 3.2 _

[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks

Stac added the comment: Hello, I am new to Python issues tracker. I had the error described above. I worked on it. I was not able to solve the issue only using subprocess. The command has to be correctly formated (with the double quotes). I corrected the cmdline definition as described first

[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks

Christian Heimes added the comment: The quoting issue on Windows can easily be fixed by using subprocess instead of popen() -- nosy: +tiran priority: -> low versions: +Python 2.5, Python 2.6, Python 3.0 -Python 2.3 __ Tracker <[EMAIL PROTECTED]>

[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks

Guido van Rossum added the comment: Please submit a patch -- this was mostly intended as demo code, I didn't expect anyone to use it, let alone on Windows. :-) -- nosy: +gvanrossum __ Tracker <[EMAIL PROTECTED]>

[issue1235] CGIHTTPRequestHandler.run_cgi() does not run on Windows if sys.executable contains blanks

New submission from Andy Schumann: On Windows a path can contain spaces (e.g. C:\Program Files\python22 \python.exe). If using popenx each component in a command line has therefore to be double quoted as well as the whole command string. The method run_cgi() of the class CGIHTTPRequestHandler in