Brett Cannon added the comment:
I went ahead and had Vim do a global search-and-replace on the names and
ditched the typedefs; the patch is uploaded. I have not yet run the
test suite, though, which is why I have not committed it. But if it
passes I will just check it in.
--
assignee:
Brett Cannon added the comment:
Applied my patch in r58399. Thanks for noticing the inconsistency, anthon!
--
resolution: - fixed
status: open - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1238
__
Changes by Martin v. Löwis:
--
keywords: +patch
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1238
__
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brett Cannon:
--
priority: - low
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1238
__
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
While I understand the argument for faster recompiles, dictobject.(c|h)
do not change that often, and thus faster recompiles are not critical.
I am with Guido and would rather see the module moved over to public names.
Setting the priority to low as this is not
Anthon van der Neut added the comment:
Guido's suggestion to change all entries to PyDictEntry resp.
PyDictObject would work as well and declutter the code in a better way.
The only advantage of the typedefs that I see (and briefly used) it that
it is easy to have structures local to
New submission from Anthon van der Neut:
In dictobject.c the structures from dictobject.h are typedeffed to:
typedef PyDictEntry dictentry;
typedef PyDictObject dictobject;
However there are still a few locations in that file where the
PyDictEntry and PyDictObject types are used directly. IMHO
Guido van Rossum added the comment:
I think it would be better to get rid of the typedefs and use the public
Py* names everywhere?
--
nosy: +gvanrossum
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1238
__
