[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

Berker Peksag added the comment: Thank you for your patch, William. I added a test case, a NEWS entry and committed it to 3.6 and master branches. -- components: +Library (Lib) nosy: +paul.moore, steve.dower, zach.ware resolution: -> fixed stage: patch review -> resolved status: open

[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

Berker Peksag added the comment: New changeset bfa89b21e119bac7fed4a5decc26f1fff8ec359e by Berker Peksag (Miss Islington (bot)) in branch '3.6': bpo-12382: Make OpenDatabase() raise better exception messages (GH-4528) https://github.com/python/cpython/commit/bfa89b21e119bac7fed4a5decc26f1fff8e

[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

Change by Roundup Robot : -- pull_requests: +4472 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

Berker Peksag added the comment: New changeset 4864a619dc1cc9092780ccf5a6327e8abf66133d by Berker Peksag in branch 'master': bpo-12382: Make OpenDatabase() raise better exception messages (GH-4528) https://github.com/python/cpython/commit/4864a619dc1cc9092780ccf5a6327e8abf66133d --

[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

Change by Berker Peksag : -- pull_requests: +4464 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

Change by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

William Tisäter added the comment: Found this a simple fix for an annoying and time consuming error. Patched as discussed earlier and decided to leave the filename out. -- components: +Windows -Library (Lib) keywords: +patch nosy: +tiwilliam versions: +Python 3.5 Added file: http://bugs

[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

Martin v. Löwis added the comment: I'd add them to msierror, with no inclusion of the file name. If you want the file name in the exception, you should uniformly apply this to all errors in OpenDatabase, and then subclass MSIError to, say, MSIOpenError which includes a .filename attribute. -

[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

Robin Jarry added the comment: This sounds OK as long as the error message is explicit :) -- ___ Python tracker ___ ___ Python-bugs-l

[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

Mark Mc Mahon added the comment: The following two error conditions that can be returned by MsiOpenDatabase do not have specific handling: ERROR_CREATE_FAILED (1631) The database could not be created. ERROR_OPEN_FAILED (110) The database could not be opened as requested. (the message

[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

Changes by Tim Golden : -- nosy: +markmcmahon, tim.golden ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

Robin Jarry added the comment: changed the headline of the defect for something more meaningful :) -- title: [msilib] Ambiguous exception message when trying to open a non existing MSI database -> [msilib] Obscure exception message when trying to open a non-existent MSI database