[issue12411] cgi.parse_multipart is broken on 3.x

Change by Irit Katriel : -- status: open -> pending ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12411] cgi.parse_multipart is broken on 3.x

Change by STINNER Victor : -- nosy: -vstinner status: pending -> open ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue12411] cgi.parse_multipart is broken on 3.x

Irit Katriel added the comment: Senthil, was this last part done in issue29979? -- nosy: +iritkatriel status: open -> pending ___ Python tracker ___

[issue12411] cgi.parse_multipart is broken on 3.x

Changes by Tal Einat talei...@gmail.com: -- nosy: -taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12411 ___ ___ Python-bugs-list mailing

[issue12411] cgi.parse_multipart is broken on 3.x

Roundup Robot added the comment: New changeset a46a0dafcb7a by Senthil Kumaran in branch '3.2': Issue #12411: Fix to cgi.parse_multipart to correctly use bytes boundaries and http://hg.python.org/cpython/rev/a46a0dafcb7a New changeset 59ea872d8b6b by Senthil Kumaran in branch '3.3': merge from

[issue12411] cgi.parse_multipart is broken on 3.x

Senthil Kumaran added the comment: I updated the patch addressing Ezio's comments in the review system and also condensed the tests. This fixes the parse_multipart's byte handling at some level. The docstring of parse_multipart say that, this should be deprecated in favor of FieldStorage

[issue12411] cgi.parse_multipart is broken on 3.x

Guido van Rossum added the comment: Twisted would really like to see this bug fixed. -- nosy: +gvanrossum ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12411 ___

[issue12411] cgi.parse_multipart is broken on 3.x

Changes by Glyph Lefkowitz gl...@twistedmatrix.com: -- nosy: +glyph ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12411 ___ ___ Python-bugs-list

[issue12411] cgi.parse_multipart is broken on 3.x

Guido van Rossum added the comment: Does anyone who was on this bug previously (e.g. the original author or the reviewers) know what was holding up the patch? Does it need more review? More tests? Is there any reason to reject fixing this at all? (I hope not.) As far as replacing the whole thing

[issue12411] cgi.parse_multipart is broken on 3.x

Senthil Kumaran added the comment: I personally think, that the grey area of multipart form encoding and trying to use email's updated features for parsing was holding it, not the tests. This can be submitted IMO after looking at the related bugs, I shall do a review on this one today.

[issue12411] cgi.parse_multipart is broken on 3.x

Guido van Rossum added the comment: Thank you very much Senthil! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12411 ___ ___ Python-bugs-list

[issue12411] cgi.parse_multipart is broken on 3.x

Changes by Florent Xicluna florent.xicl...@gmail.com: -- nosy: +orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12411 ___ ___

[issue12411] cgi.parse_multipart is broken on 3.x

Tal Einat talei...@gmail.com added the comment: The patch seems broken to me. In cgi.parse_multipart(), the 'boundary' variable can be a string even though it is concatenated to bytes. Its default value is a string, and a string can be given via the pdict argument. There is no validity check

[issue12411] cgi.parse_multipart is broken on 3.x

Jonas Wagner ve...@gmx.ch added the comment: Hi Tal, Thanks a lot for your feedback. My primary objective was to increase the test coverage for cgi.py. If it is a problem to have the additional tests in this patch I'm happy to create a new issue with a separate patch. The default value for

[issue12411] cgi.parse_multipart is broken on 3.x

Tal Einat talei...@gmail.com added the comment: Yes, please submit the other additional tests in a separate issue. The default value for boundary should surely be b. A simple test should be added where cgi.parse_multipart() uses the default boundary. If valid_boundary() is used only for

[issue12411] cgi.parse_multipart is broken on 3.x

Pierre Quentel pierre.quen...@gmail.com added the comment: When the FieldStorage class was fixed there was a discussion in issue 4953 about the module-level functions parse() and parse_multipart(). The code was very similar to methods of the FieldStorage class so the idea was to use

[issue12411] cgi.parse_multipart is broken on 3.x

Éric Araujo mer...@netwok.org added the comment: This looks like a conversion bug indeed; network I/O should use bytes. Strange that no-one caught this, but if there was no test and no users, then bugs can slip. See also #11066, #8077, #4953, #6234 (also adding some people from those bugs’

[issue12411] cgi.parse_multipart is broken on 3.x

R. David Murray rdmur...@bitdance.com added the comment: Indeed, Victor's comments on his patch say that he changed code that was in the posted patch to say 'line.startswith(b'--')', and the original patch did use b'--', but the code he checked in is missing the 'b'. He also asked for more

[issue12411] cgi.parse_multipart is broken on 3.x

New submission from Jonas Wagner ve...@gmx.ch: While writing tests for the cgi module I came across what looks like a conversion bug. cgi.parse_multipart is comparing values it reads from a binary file like with a string literal: line = fp.readline() ... if line.startswith(--): This patch

[issue12411] cgi.parse_multipart is broken on 3.x

Changes by R. David Murray rdmur...@bitdance.com: -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12411 ___ ___ Python-bugs-list