[issue12420] distutils tests fail if PATH is not defined

Terry J. Reedy added the comment: test_distutils now passes on 3.6, so this is out-of-date for 3.x. On installed 2.7.13 (released Dec 2016) ERROR: test_get_outputs (distutils.tests.test_build_ext.BuildExtTestCase) FAIL: test_customize_compiler_before_get_config_vars (distutils.tests.test_sysco

[issue12420] distutils tests fail if PATH is not defined

Terry J. Reedy added the comment: No VS2015 yet. New issue #25100. Thanks. -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue12420] distutils tests fail if PATH is not defined

Zachary Ware added the comment: Agreed with Mark; I don't see anywhere that lack of PATH would affect the failures you're seeing, Terry. Do you have VS2015 installed? If not, the failure of distutils to skip the tests that need it should be raised as a separate issue. -- __

[issue12420] distutils tests fail if PATH is not defined

Mark Lawrence added the comment: "Unable to find vcvarsall.bat" is raised when Visual Studio isn't installed or it's the incorrect version, so I don't believe these are the same at all. -- components: -Distutils2 nosy: +dstufft ___ Python tracker <

[issue12420] distutils tests fail if PATH is not defined

Terry J. Reedy added the comment: The following failures on new 3.5.0 seems related as they all end with the same message about vcvarsall.bat (slightly different from 3.4 failures). == ERROR: test_get_outputs (distutils.tests.t

[issue12420] distutils tests fail if PATH is not defined

Changes by Terry J. Reedy : -- versions: +Python 3.5 -Python 3.3 Added file: http://bugs.python.org/file35798/distutils-12420.diff ___ Python tracker ___

[issue12420] distutils tests fail if PATH is not defined

Terry J. Reedy added the comment: A minor change: distutils has is own version of sysconfig*, which is already imported into disutils/tests/test_build_ext.py. It has '_python_build' instead of 'is_python_build'. With that change, the decorators work as expected to skip the tests on installed W

[issue12420] distutils tests fail if PATH is not defined

Terry J. Reedy added the comment: I feel that conscientious users who test their installations should get a clean test. They cannot be expected to know that this is an 'expected failure' and therefore not really a failure. Test_tools has the following, which indeed works to skip on installed 3

[issue12420] distutils tests fail if PATH is not defined

Nick Coghlan added the comment: Skipping if the compiler isn't available is problematic, since that could reflect a real failure mode for the code. -- ___ Python tracker ___ ___

[issue12420] distutils tests fail if PATH is not defined

Nick Coghlan added the comment: For Python 3, I suggest tweaking the code to use shutil.which and see if that improves matters. For Python 2, I'm inclined not to worry about it. -- ___ Python tracker

[issue12420] distutils tests fail if PATH is not defined

Terry J. Reedy added the comment: test_disutils still fails on both 2.7 and 3.4 installs. Since PATH is defined, that is not the issue here. I am tempted to unconditionally skip the test and close this issue. -- ___ Python tracker

[issue12420] distutils tests fail if PATH is not defined

Mark Lawrence added the comment: Can someone follow up on this please. See also #12401. -- nosy: +BreamoreBoy ___ Python tracker ___

[issue12420] distutils tests fail if PATH is not defined

Terry J. Reedy added the comment: I just ran into this issue (same I believe) running the test suite with installed, versus repository, python on win7, but get a different traceback. Traceback (most recent call last): ...\lib\distutils\tests\test_build_ext.py" line 156, in test_optional_ext

[issue12420] distutils tests fail if PATH is not defined

Éric Araujo added the comment: Sorry, I don’t want to monkey-patch find_executable during tests. We want the tests to work with the real code, with the same behavior and errors as real setup.py calls. If a test does not work with python -E, then it should be skipped. (Implementation idea:

[issue12420] distutils tests fail if PATH is not defined

Henry Precheur added the comment: I've fixed the last failing tests, but I'm unsure it's the right way to do it. Take a look at the part for Lib/distutils/tests/test_build_ext.py. I just check that os.environ['PATH'] is defined. I'm not 100% certain that this will work on every platforms. --

[issue12420] distutils tests fail if PATH is not defined

Changes by Henry Precheur : Removed file: http://bugs.python.org/file22501/fix_distutils_test.diff ___ Python tracker ___ ___ Python-bugs-list

[issue12420] distutils tests fail if PATH is not defined

Henry Precheur added the comment: OK it makes sense. I'm working on fixing the tests. I'm not done yet, but I've attached a patch with my work in progress (some tests still fail). Do you have any comments? I'll post a complete version later today or tomorrow. -- Added file: http://bu

[issue12420] distutils tests fail if PATH is not defined

Éric Araujo added the comment: To explain my position: distutils is a very brittle codebase that’s used and monkey-patched by a lot of third-party code. In the past, before the forking of distutils/packaging, Tarek tried to gradually improve distutils but he got a lot of pushback when his ch

[issue12420] distutils tests fail if PATH is not defined

Changes by Henry Precheur : -- title: distutils crashes if PATH is not defined -> distutils tests fail if PATH is not defined ___ Python tracker ___