[issue12639] msilib Directory.start_component() fails if keyfile is not None

Pablo Galindo Salgado added the comment: test_msilib is leaking references https://bugs.python.org/issue37124 -- nosy: +pablogsal ___ Python tracker ___ __

[issue12639] msilib Directory.start_component() fails if keyfile is not None

Steve Dower added the comment: New changeset bfc1f605609218b9734d3cf3eab3531a2f4624e1 by Steve Dower (Miss Islington (bot)) in branch '2.7': [2.7] bpo-12639: msilib.Directory.start_component() fails if *keyfile* is not None (GH-13688) https://github.com/python/cpython/commit/bfc1f605609218b9

[issue12639] msilib Directory.start_component() fails if keyfile is not None

Change by Steve Dower : -- resolution: -> fixed stage: backport needed -> resolved status: open -> closed ___ Python tracker ___ __

[issue12639] msilib Directory.start_component() fails if keyfile is not None

Zackery Spytz added the comment: Thanks for looking at this issue, Steve. At this point in time, 3.6 only takes security fixes, so PR 13703 should be closed. The Close() method was added in 3.7, so I think removing the addCleanup() call is the way to go for 2.7. -- ___

[issue12639] msilib Directory.start_component() fails if keyfile is not None

Steve Dower added the comment: Looks like the tests need to be customized for 2.7 and 3.6: Traceback (most recent call last): File "D:\a\1\s\lib\test\test_msilib.py", line 64, in test_directory_start_component_keyfile self.addCleanup(db.Close) AttributeError: '_msi.Database' object has

[issue12639] msilib Directory.start_component() fails if keyfile is not None

miss-islington added the comment: New changeset 49fc57abf5fcf60129e460046d78c9bf20a19931 by Miss Islington (bot) in branch '3.7': bpo-12639: msilib.Directory.start_component() fails if *keyfile* is not None (GH-13688) https://github.com/python/cpython/commit/49fc57abf5fcf60129e460046d78c9bf2

[issue12639] msilib Directory.start_component() fails if keyfile is not None

Change by miss-islington : -- pull_requests: +13589 pull_request: https://github.com/python/cpython/pull/13703 ___ Python tracker ___ __

[issue12639] msilib Directory.start_component() fails if keyfile is not None

Steve Dower added the comment: Thanks, Zackery! The backports are running CI now and should merge if everything passes. -- stage: patch review -> backport needed ___ Python tracker _

[issue12639] msilib Directory.start_component() fails if keyfile is not None

Change by miss-islington : -- pull_requests: +13590 pull_request: https://github.com/python/cpython/pull/13704 ___ Python tracker ___ __

[issue12639] msilib Directory.start_component() fails if keyfile is not None

Steve Dower added the comment: New changeset c8d5bf6c3fa09b43f6a5ee779d493d251dbcc53c by Steve Dower (Zackery Spytz) in branch 'master': bpo-12639: msilib.Directory.start_component() fails if *keyfile* is not None (GH-13688) https://github.com/python/cpython/commit/c8d5bf6c3fa09b43f6a5ee779d

[issue12639] msilib Directory.start_component() fails if keyfile is not None

Change by miss-islington : -- pull_requests: +13591 pull_request: https://github.com/python/cpython/pull/13705 ___ Python tracker ___ __

[issue12639] msilib Directory.start_component() fails if keyfile is not None

Change by Zackery Spytz : -- nosy: +ZackerySpytz type: -> behavior versions: +Python 2.7, Python 3.7, Python 3.8 -Python 3.4, Python 3.5 ___ Python tracker ___ ___

[issue12639] msilib Directory.start_component() fails if keyfile is not None

Change by Zackery Spytz : -- pull_requests: +13576 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13688 ___ Python tracker ___ ___

[issue12639] msilib Directory.start_component() fails if keyfile is not None

Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue12639] msilib Directory.start_component() fails if keyfile is not None

Steve Dower added the comment: I guess it's okay, but I have literally zero knowledge or experience with the msilib module. Martin is still maintainer for that, as far as I know. -- ___ Python tracker

[issue12639] msilib Directory.start_component() fails if keyfile is not None

Mark Lawrence added the comment: @Steve can you take a look at the patch please, it only changes one line. -- nosy: +BreamoreBoy ___ Python tracker ___ __

[issue12639] msilib Directory.start_component() fails if keyfile is not None

Changes by Mark Lawrence : -- nosy: +loewis, steve.dower versions: +Python 3.5 -Python 2.6, Python 2.7, Python 3.1, Python 3.2, Python 3.3 ___ Python tracker ___ ___

[issue12639] msilib Directory.start_component() fails if keyfile is not None

New submission from John Keeping : If msilib.Directory.start_component() is called with the keyfile argument not None then it attempts to call self.cab.gen_id(self.absolute, keyfile) but the msilib.CAB.gen_id() method takes only two arguments (not three). -- components: Windows files: