Charles-François Natali neolo...@free.fr added the comment:
The test now passes on the buildbots, closing.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12650
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 9ee802642d86 by Charles-François Natali in branch '2.7':
Issue #12650: Fix a race condition where a subprocess.Popen could leak
http://hg.python.org/cpython/rev/9ee802642d86
--
nosy: +python-dev
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 7d358379c5fb by Charles-François Natali in branch '2.7':
Issue #12650: only run the tests on Unix.
http://hg.python.org/cpython/rev/7d358379c5fb
--
___
Python tracker
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 8ca7f109ce79 by Charles-François Natali in branch '3.2':
Issue #12650: Fix a race condition where a subprocess.Popen could leak
http://hg.python.org/cpython/rev/8ca7f109ce79
--
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 148d75d106f1 by Charles-François Natali in branch 'default':
Issue #12650: Fix a race condition where a subprocess.Popen could leak
http://hg.python.org/cpython/rev/148d75d106f1
--
Charles-François Natali neolo...@free.fr added the comment:
Patch committed.
This should also fix the original problem.
Gabriele, thanks for the report.
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker
Charles-François Natali neolo...@free.fr added the comment:
Reopening.
The new tests are failing on solaris and Debian parallel buildbots:
http://www.python.org/dev/buildbot/all/builders/x86 debian parallel
3.x/builds/2734/steps/test/logs/stdio
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 122f952add3c by Charles-François Natali in branch '3.2':
Issue #12650: fix failures on some buildbots, when a subprocess takes a long
http://hg.python.org/cpython/rev/122f952add3c
New changeset a32ae2749cd1 by
Charles-François Natali neolo...@free.fr added the comment:
This means that the child process didn't get reaped by _cleanup().
The most likely cause is that when _cleanup() calls waitpid(pid, WNOHANG), the
child process hasn't exited yet.
Since I had already set a rather high timeout to avoid
New submission from gabriele.trombetti g.trombe...@plasmacore.com:
There seems to be a file descriptor (fd) leak in subprocess upon call to kill()
and then destroying the current subprocess object (e.g. by scope exit) if the
pipe functionality is being used.
This is a reproducer:
(Linux
Changes by R. David Murray rdmur...@bitdance.com:
--
nosy: +gregory.p.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12650
___
___
Charles-François Natali neolo...@free.fr added the comment:
There's indeed a leak in your code, because you don't close the stdout and
stderr file descriptors.
Try with:
subp.terminate()
subp.stdout.close()
subp.stderr.close()
return True
And you'll be just fine.
The reason
Changes by STINNER Victor victor.stin...@haypocalc.com:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12650
___
___
Changes by Ross Lagerwall rosslagerw...@gmail.com:
--
nosy: +rosslagerwall
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12650
___
___
Charles-François Natali neolo...@free.fr added the comment:
Alright.
I tested this on default, and couldn't reproduce the FD leak.
It turned out to be due to another bug, affecting only the code path
which calls pure C _posixsubprocess (which is the only implementation
left in 3.3, but 3.2
Ross Lagerwall rosslagerw...@gmail.com added the comment:
The patches look good and seem to fix the issue.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12650
___
16 matches
Mail list logo
