[issue12684] profile does not dump stats on exception like cProfile does

Change by Irit Katriel : -- resolution: -> duplicate stage: patch review -> resolved status: open -> closed superseder: -> c/profile refactoring ___ Python tracker ___ __

[issue12684] profile does not dump stats on exception like cProfile does

Giampaolo Rodola' added the comment: I wasn't aware of this issue (sorry) and I have already fixed this back in cset 422169310b7c for the 3.4 branch. 2.7, 3.2 and 3.3 branches can still be fixed though. -- versions: +Python 2.7 -Python 3.4 ___ Python

[issue12684] profile does not dump stats on exception like cProfile does

Changes by Ezio Melotti : -- nosy: +giampaolo.rodola versions: +Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue12684] profile does not dump stats on exception like cProfile does

Matt Joiner added the comment: I attached a minimal patch that additionally tidies the exception handling for {cP,p}rofile.runctx. -- ___ Python tracker ___ ___

[issue12684] profile does not dump stats on exception like cProfile does

Changes by Matt Joiner : Added file: http://bugs.python.org/file24961/profiler-unhandled-exceptions.patch ___ Python tracker ___ ___ Python-bu

[issue12684] profile does not dump stats on exception like cProfile does

Matt Joiner added the comment: I will submit a patch for this soon. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue12684] profile does not dump stats on exception like cProfile does

Georg Brandl added the comment: The same fix should be applied to runctx() too. The SystemExit handling is fine, it's in the original code also. I would recommend making a single try-except-finally statement. -- ___ Python tracker

[issue12684] profile does not dump stats on exception like cProfile does

Matt Joiner added the comment: Jim the code was lifted verbatim from Lib/cProfile.py, line 47. That code in cProfile.py has not changed since 2006 when it was committed by Armin Rigo. I can modernize it if it's a requirement to get it committed, but I'm also okay with my conservative patch a

[issue12684] profile does not dump stats on exception like cProfile does

Jim Jewett added the comment: If I read that patch right, it ignores (and does not even reraise) SystemExit (unchanged), but other Exceptions currently block the dump (and your patch causes them to still dump). (1) Why is SystemExit ignored? (2) There should be tests to show that there w

[issue12684] profile does not dump stats on exception like cProfile does

Changes by Éric Araujo : -- keywords: +needs review nosy: +georg.brandl stage: -> patch review versions: -Python 3.4 ___ Python tracker ___

[issue12684] profile does not dump stats on exception like cProfile does

Changes by Matt Joiner : -- resolution: works for me -> status: languishing -> open versions: +Python 3.4 ___ Python tracker ___ ___

[issue12684] profile does not dump stats on exception like cProfile does

Changes by Matt Joiner : -- resolution: -> works for me status: open -> languishing ___ Python tracker ___ ___ Python-bugs-list maili

[issue12684] profile does not dump stats on exception like cProfile does

Matt Joiner added the comment: Also affects 3.3. -- versions: +Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue12684] profile does not dump stats on exception like cProfile does

New submission from Matt Joiner : Here's a patch that fixes it. -- components: Library (Lib) files: exception-in-profile.patch keywords: patch messages: 141591 nosy: anacrolix priority: normal severity: normal status: open title: profile does not dump stats on exception like cProfile doe