[issue12707] Deprecate addinfourl getters

Stéphane Wirtel added the comment: Thank you so much for your contribution, I close this issue and have merged the PR. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue12707] Deprecate addinfourl getters

Stéphane Wirtel added the comment: New changeset ff2e18286560e981f4e09afb0d2448ea994414d8 by Stéphane Wirtel (Ashwin Ramaswami) in branch 'master': bpo-12707: deprecate info(), geturl(), getcode() methods in favor of headers, url, and status properties for HTTPResponse and addinfourl

[issue12707] Deprecate addinfourl getters

Change by Stéphane Wirtel : -- versions: +Python 3.9 -Python 2.7, Python 3.3, Python 3.4 ___ Python tracker ___ ___ Python-bugs-list

[issue12707] Deprecate addinfourl getters

Change by Demian Brecht : -- nosy: +demian.brecht ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12707] Deprecate addinfourl getters

Change by Ashwin Ramaswami : -- keywords: +patch, patch, patch, patch pull_requests: +10905, 10906, 10907, 10908 stage: needs patch -> patch review ___ Python tracker ___

[issue12707] Deprecate addinfourl getters

Change by Ashwin Ramaswami : -- keywords: +patch, patch, patch pull_requests: +10905, 10906, 10908 stage: needs patch -> patch review ___ Python tracker ___

[issue12707] Deprecate addinfourl getters

Change by Ashwin Ramaswami : -- keywords: +patch, patch pull_requests: +10905, 10906 stage: needs patch -> patch review ___ Python tracker ___

[issue12707] Deprecate addinfourl getters

Change by Ashwin Ramaswami : -- keywords: +patch pull_requests: +10905 stage: needs patch -> patch review ___ Python tracker ___

[issue12707] Deprecate addinfourl getters

Martin Panter added the comment: I think it would be okay to deprecate the methods in the documentation, but they should not be removed nor trigger warnings any time soon. Currently the following related methods and attributes are documented: * addinfourl.getcode() == HTTPResponse.status ==

[issue12707] Deprecate addinfourl getters

Martin Panter added the comment: Blessing a geturl() method or “url” attribute on HTTPError might require Issue 13567 to be fixed -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12707 ___

[issue12707] Deprecate addinfourl getters

Changes by Berker Peksag berker.pek...@gmail.com: -- nosy: +berker.peksag ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12707 ___ ___

[issue12707] Deprecate addinfourl getters

Changes by Martin Panter vadmium...@gmail.com: -- nosy: +vadmium ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12707 ___ ___ Python-bugs-list

[issue12707] Deprecate addinfourl getters

Senthil Kumaran added the comment: And getcode is documented all 3.x documentation now. URLOpener (and by inheritance) raise DeprecationWarning since 3.3. I believe, when class becomes deprecated and removed, their methods go away too? For the URLOpener, I would like that to happen as it will

[issue12707] Deprecate addinfourl getters

Senthil Kumaran added the comment: URLOpener (and by inheritance *FancyURLOpener*) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12707 ___ ___

[issue12707] Deprecate addinfourl getters

Changes by Senthil Kumaran sent...@uthcode.com: -- assignee: - orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12707 ___ ___

[issue12707] Deprecate addinfourl getters

Senthil Kumaran added the comment: This commit by Ezio in the tests is related (1bcddc0a3765) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12707 ___

[issue12707] Deprecate addinfourl getters

Petri Lehtinen added the comment: +1 for the documentation changes, which should be applied to 2.7 as well. The deprecation is the only thing to go to 3.4 only, if it's done at all. -- nosy: +petri.lehtinen versions: +Python 2.7, Python 3.3 ___

[issue12707] Deprecate addinfourl getters

Petri Lehtinen added the comment: Also note that getcode() is already documented in urllib (not urllib2) documentation: http://docs.python.org/2/library/urllib.html#urllib.urlopen -- ___ Python tracker rep...@bugs.python.org

[issue12707] Deprecate addinfourl getters

Changes by Ezio Melotti ezio.melo...@gmail.com: -- type: - enhancement versions: +Python 3.4 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12707 ___

[issue12707] Deprecate addinfourl getters

Éric Araujo mer...@netwok.org added the comment: I thought about having another class, but I couldn't come up with a decent name for it (ResponseWithCloseHook?). If it’s used together with the base Response class (I don’t have the details in memory anymore), you could try ClosingMixin or

[issue12707] Deprecate addinfourl getters

Éric Araujo mer...@netwok.org added the comment: For these two reasons I propose to: * document the 3 attributes as the suggested way to access this information; * deprecate the 3 getters; * avoid to document the now undocumented getcode(); +1 The addclosehook class could be

[issue12707] Deprecate addinfourl getters

Ezio Melotti ezio.melo...@gmail.com added the comment: I thought about having another class, but I couldn't come up with a decent name for it (ResponseWithCloseHook?). After all it's still a Response and unless you need a way to distinguish responses with and without close hooks, I think it

[issue12707] Deprecate addinfourl getters

Changes by Nadeem Vawda nadeem.va...@gmail.com: -- nosy: +nadeem.vawda ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12707 ___ ___

[issue12707] Deprecate addinfourl getters

New submission from Ezio Melotti ezio.melo...@gmail.com: The documentation for urllib.request.urlopen [0] says that: This function returns a file-like object [addinfourl] with two additional methods from the urllib.response module geturl() — return the URL of the resource retrieved, [...]

[issue12707] Deprecate addinfourl getters

Ezio Melotti ezio.melo...@gmail.com added the comment: Another possible improvement that can be done is providing a proper Response object instead of addbase, addinfo, addinfourl (yes, those are oddly-named classes, not functions [0]). The Response object could be like 'addbase', but with this