[issue12743] C API marshalling doc contains XXX

Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8 -Python 3.5 ___ Python tracker ___ _

[issue12743] C API marshalling doc contains XXX

miss-islington added the comment: New changeset 146ba436cc0457b8ef7fea8b054b9ccb15e24748 by Miss Islington (bot) in branch '3.6': bpo-12743: Delete comment from marshal.rst (GH-8457) https://github.com/python/cpython/commit/146ba436cc0457b8ef7fea8b054b9ccb15e24748 -- __

[issue12743] C API marshalling doc contains XXX

miss-islington added the comment: New changeset 21ed29ac290b10d31dcac947f9246ae4d8b94a86 by Miss Islington (bot) in branch '3.7': bpo-12743: Delete comment from marshal.rst (GH-8457) https://github.com/python/cpython/commit/21ed29ac290b10d31dcac947f9246ae4d8b94a86 -- nosy: +miss-isl

[issue12743] C API marshalling doc contains XXX

Change by miss-islington : -- pull_requests: +8010 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue12743] C API marshalling doc contains XXX

Change by miss-islington : -- pull_requests: +8011 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue12743] C API marshalling doc contains XXX

Berker Peksag added the comment: New changeset defcffdf86780e3a184ebb25dc9a7b807753d57a by Berker Peksag in branch 'master': bpo-12743: Delete comment from marshal.rst (GH-8457) https://github.com/python/cpython/commit/defcffdf86780e3a184ebb25dc9a7b807753d57a -- ___

[issue12743] C API marshalling doc contains XXX

Change by Berker Peksag : -- pull_requests: +7981 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue12743] C API marshalling doc contains XXX

Changes by Berker Peksag : -- versions: +Python 3.7 Added file: http://bugs.python.org/file44871/issue12743_v2.diff ___ Python tracker ___ ___

[issue12743] C API marshalling doc contains XXX

Berker Peksag added the comment: Since 4059e871e74e, PyMarshal_ReadLongFromFile and PyMarshal_ReadShortFromFile can return -1 on error. Return values of those functions were already documented in acb4d43955f6. Some of the usages also check return value of PyErr_Occurred(): https://hg.python.or

[issue12743] C API marshalling doc contains XXX

Changes by Serhiy Storchaka : -- stage: -> needs patch type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue12743] C API marshalling doc contains XXX

Ronald Oussoren added the comment: >From reading the source of Python/marshal.c it seems that the read function's >raise an exception on I/O errors, but don't return a specific value (that is, >sentence starting with "It appears that" is wrong). PyMarshal_ReadLongFromFile calls r_long, this c

[issue12743] C API marshalling doc contains XXX

Martin v. Löwis added the comment: Would you just remove the "XXX" string, or the entire comment? "XXX" is typically used to indicate that something needs to be done, and the comment makes a clear statement as to what it is that needs to be done. -- nosy: +loewis

[issue12743] C API marshalling doc contains XXX

Éric Araujo added the comment: It should be removed if someone is confident that it’s a obsolete comment, or if tests get added to answer the questions in the note. -- nosy: +eric.araujo ___ Python tracker __

[issue12743] C API marshalling doc contains XXX

New submission from JJeffries : The Python C API manual page for data marshaling contains the following paragraph. XXX What about error detection? It appears that reading past the end of the file will always result in a negative numeric value (where that’s relevant), but it’s not clear that n