[issue12810] Remove check for negative unsigned value in socketmodule.c

Charles-François Natali added the comment: Patch committed. Thanks Joel! -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker __

[issue12810] Remove check for negative unsigned value in socketmodule.c

Roundup Robot added the comment: New changeset 4736e172fa61 by Charles-François Natali in branch 'default': Issue12810: Remove check for negative unsigned value in socketmodule.c. Patch http://hg.python.org/cpython/rev/4736e172fa61 -- nosy: +

[issue12810] Remove check for negative unsigned value in socketmodule.c

Joel added the comment: My full name is Joel Stanley, and yep, please add me to Misc/ACKS. -- ___ Python tracker ___ ___ Python-bugs-

[issue12810] Remove check for negative unsigned value in socketmodule.c

Charles-François Natali added the comment: Thanks. I'll commit this patch tomorrow. I noticed you didn't indicate your full name: do you mind being listed in Misc/ACKS? -- components: +Extension Modules keywords: +easy nosy: +neologix stage: -> commit review type: -> behavior version

[issue12810] Remove check for negative unsigned value in socketmodule.c

New submission from Joel : fixes the following warning: cpython/Modules/socketmodule.c:1748:74: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare] if (cmsgh == NULL || msg->msg_control == NULL || msg->msg_controllen < 0) -- files: bad_unsigned_c