[issue12841] Incorrect tarfile.py extraction

Éric Araujo added the comment: I understand. Unit tests can work with file permissions, ownership and links, but they can’t create different filesystems or ask for superuser rights. test_shutil contains a few tests that purport to test cross-filesystems usage but may or may not actually do

[issue12841] Incorrect tarfile.py extraction

Lars Gustäbel added the comment: It's the low-level operating system aspects of tarfile that are very difficult to test, e.g. filesystem and operating system dependent features such as symbolic links, hard links, file permissions, ownership. It is not even possible to reliably determine the f

[issue12841] Incorrect tarfile.py extraction

Éric Araujo added the comment: > I think we have to go without a unit test. May I ask why? I don’t know tarfile well, but I know that a lot can be done with unittest. -- nosy: +eric.araujo ___ Python tracker ___

[issue12841] Incorrect tarfile.py extraction

Lars Gustäbel added the comment: Close as fixed. Thanks all! -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue12841] Incorrect tarfile.py extraction

Roundup Robot added the comment: New changeset 2bc122347351 by Lars Gustäbel in branch '3.2': Issue #12841: Fix tarfile extraction of non-existent uids/gids. http://hg.python.org/cpython/rev/2bc122347351 New changeset da59abc0ce3b by Lars Gustäbel in branch 'default': Merge with 3.2: Issue #128

[issue12841] Incorrect tarfile.py extraction

Changes by Doug Hellmann : -- nosy: +doughellmann ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue12841] Incorrect tarfile.py extraction

Changes by Lars Gustäbel : -- versions: +Python 2.7, Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12841] Incorrect tarfile.py extraction

STINNER Victor added the comment: You can get a lot of information on this guide: http://docs.python.org/devguide/setup.html#getting-set-up You can also ask on IRC (#python-dev on Freenode), or by email on the python-dev mailing list. It was really hard for me to switch from Subversion to Mer

[issue12841] Incorrect tarfile.py extraction

Lars Gustäbel added the comment: Yes, I can do that as soon as I've managed to wrap my head around using Mercurial and the new way of developing Python. I have been away from Python programming for quite some time and haven't adapted my workflow yet. -- __

[issue12841] Incorrect tarfile.py extraction

STINNER Victor added the comment: The patch looks ok. Can you push it Lars? -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue12841] Incorrect tarfile.py extraction

Lars Gustäbel added the comment: Yes, it should be fixed in all affected branches. -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue12841] Incorrect tarfile.py extraction

STINNER Victor added the comment: Should this bug be fixed in 3.3, or 2.7+3.2+3.3? -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue12841] Incorrect tarfile.py extraction

Lars Gustäbel added the comment: The patch is fine. Thank you very much for it, Sebastien. I think we have to go without a unit test. -- ___ Python tracker ___

[issue12841] Incorrect tarfile.py extraction

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue12841] Incorrect tarfile.py extraction

Martin v. Löwis added the comment: Lars, any comment? -- assignee: -> lars.gustaebel nosy: +lars.gustaebel, loewis ___ Python tracker ___ __

[issue12841] Incorrect tarfile.py extraction

New submission from Sebastien Luttringer : This patch fix extraction of tarfile which override tarfile uid/gid tarfile.py extract function override uid/gid of a file if uid/gid is not existant on the system. When user is not root (uid 0), common behaviour of extracting is correct. When user is