[issue12932] filecmp.dircmp does not allow non-shallow comparisons

Change by Mitar : -- nosy: +mitar ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue12932] filecmp.dircmp does not allow non-shallow comparisons

Robert Collins added the comment: Thanks for the patch @planet36, however I think this is sufficiently large a change that we should also have a test case for it. I'm also retargeting this to the current open branches for feature work - 3.6. -- nosy: +rbcollins stage: commit review -

[issue12932] filecmp.dircmp does not allow non-shallow comparisons

Robert Collins added the comment: Bah, wrong stage. patch review. -- stage: test needed - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12932 ___

[issue12932] filecmp.dircmp does not allow non-shallow comparisons

Changes by R. David Murray rdmur...@bitdance.com: -- stage: needs patch - commit review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12932 ___

[issue12932] filecmp.dircmp does not allow non-shallow comparisons

Steve Ward added the comment: Add input parameter 'shallow' to dircmp. Use it in phase3 and phase4. Document it in filecmp.rst. Did not modify test_filecmp.py. -- keywords: +patch Added file: http://bugs.python.org/file30589/issue12932.diff ___

[issue12932] filecmp.dircmp does not allow non-shallow comparisons

Changes by Steve Ward plane...@gmail.com: -- nosy: +planet36 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12932 ___ ___ Python-bugs-list mailing

[issue12932] filecmp.dircmp does not allow non-shallow comparisons

Chris Jerdonek chris.jerdo...@gmail.com added the comment: Allowing dircmp() to accept a file comparison function is another option to consider that may address more needs going forward. shallow=False could be achieved by passing lambda a, b: filecmp.cmp(a, b, shallow=False). --

[issue12932] filecmp.dircmp does not allow non-shallow comparisons

Chris Jerdonek chris.jerdo...@gmail.com added the comment: +1 for this. Whether or not this feature is implemented, I think the documentation should state that directory comparisons are done using shallow=True. I created issue 15250 for this. -- nosy: +cjerdonek

[issue12932] filecmp.dircmp does not allow non-shallow comparisons

Changes by Éric Araujo mer...@netwok.org: -- stage: test needed - needs patch title: dircmp does not allow non-shallow comparisons - filecmp.dircmp does not allow non-shallow comparisons ___ Python tracker rep...@bugs.python.org