[issue1303614] Bypassing __dict__ readonlyness

Guido van Rossum added the comment: Reopening, since test67.py still causes a segfault in the trunk. It is represented as Lib/test/crashers/loosing_dict_ref.py [sic]. -- nosy: +gvanrossum priority: normal -> urgent status: closed -> open _ Tracker <[

[issue1303614] Bypassing __dict__ readonlyness

Guido van Rossum added the comment: Armin, what do you think of the attached patch (deldict.diff)? Added file: http://bugs.python.org/file9274/deldict.diff _ Tracker <[EMAIL PROTECTED]> ___

[issue1303614] Bypassing __dict__ readonlyness

Guido van Rossum added the comment: Here's a better fix, which also fixes the similar code path in GenericSetAttr(). As a bonus, I reviewed all uses of _PyObject_GetDictPtr() and found one questionable place where the dict at *dictptr was DECREF'ed before that location was set to NULL. I think

[issue1303614] Bypassing __dict__ readonlyness

Changes by Guido van Rossum: Added file: http://bugs.python.org/file9275/deldict.diff _ Tracker <[EMAIL PROTECTED]> _ ___ Python-bugs-list ma

[issue1303614] Bypassing __dict__ readonlyness

Changes by Guido van Rossum: Removed file: http://bugs.python.org/file9274/deldict.diff _ Tracker <[EMAIL PROTECTED]> _ ___ Python-bugs-list

[issue1303614] Bypassing __dict__ readonlyness

Changes by Neal Norwitz: -- nosy: +nnorwitz _ Tracker <[EMAIL PROTECTED]> _ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue1303614] Bypassing __dict__ readonlyness

Guido van Rossum added the comment: The more i think about it, I don't think the issue in typeobject.c can ever occur, so I'm skipping that part of the fix. _ Tracker <[EMAIL PROTECTED]> ___

[issue1303614] Bypassing __dict__ readonlyness

Changes by Adam Olsen: -- nosy: +Rhamphoryncus _ Tracker <[EMAIL PROTECTED]> _ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue1303614] Bypassing __dict__ readonlyness

Neal Norwitz added the comment: I looked at Guido's latest deldict.diff patch--the one to Objects/object.c only. It seems good. I can't convince myself either way about the change to Objects/typeobject.c. I can't think of a way to cause a problem. It seems safer to use Py_CLEAR in this case t

[issue1303614] Bypassing __dict__ readonlyness

Guido van Rossum added the comment: On Jan 23, 2008 11:12 PM, Neal Norwitz <[EMAIL PROTECTED]> wrote: > > Neal Norwitz added the comment: > > I looked at Guido's latest deldict.diff patch--the one to > Objects/object.c only. It seems good. I can't convince myself either > way about the change t

[issue1303614] Bypassing __dict__ readonlyness

Guido van Rossum added the comment: r60247 (2.5.2 branch), r60246 (2.6 trunk). -- resolution: -> fixed status: open -> closed _ Tracker <[EMAIL PROTECTED]> _ __