Changes by Antoine Pitrou pit...@free.fr:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13146
___
___
Python-bugs-list
Barry A. Warsaw added the comment:
On Aug 15, 2013, at 08:25 PM, Antoine Pitrou wrote:
Barry, do you still want to keep this issue open?
I don't necessarily need to. We've patched the Ubuntu version to be safe, so
I guess we'll just carry that delta along until 3.4.
--
Antoine Pitrou added the comment:
Barry, do you still want to keep this issue open?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13146
___
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13146
___
Changes by Barry A. Warsaw ba...@python.org:
--
nosy: +doko
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13146
___
___
Python-bugs-list mailing
Barry A. Warsaw added the comment:
Proposed patch for 2.7
--
Added file: http://bugs.python.org/file30324/13146-2.7.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13146
___
Barry A. Warsaw added the comment:
I'm re-opening this because I'd like to get RM pronouncement on applying a
patch to 2.7, 3.2, and 3.3 to make py_compile.py atomically rename its pyc/pyo
file.
Attached is a patch for 2.7 based on importlib's approach in 3.4. It should be
easy enough to
Barry A. Warsaw added the comment:
Oh btw, if Georg and Benjamin deny this for the stable releases, I'll very
likely patch the Ubuntu versions anyway.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13146
Antoine Pitrou added the comment:
I'm re-opening this because I'd like to get RM pronouncement on
applying a patch to 2.7, 3.2, and 3.3 to make py_compile.py atomically
rename its pyc/pyo file.
Some people already complained about this change. I'm not sure it's fit
for a bugfix release.
Barry A. Warsaw added the comment:
On May 20, 2013, at 09:52 PM, Antoine Pitrou wrote:
Some people already complained about this change. I'm not sure it's fit for a
bugfix release. http://bugs.python.org/issue17222
Yeah, but that's a crazy use case. :)
Besides, you can just also make
Charles-François Natali added the comment:
IIRC, os.rename() will fail on Windows if the target file already exists.
That's why os.replace() was added.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13146
Antoine Pitrou added the comment:
IIRC, os.rename() will fail on Windows if the target file already
exists.
Good point.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13146
___
Barry A. Warsaw added the comment:
On May 20, 2013, at 09:57 PM, Charles-François Natali wrote:
IIRC, os.rename() will fail on Windows if the target file already exists.
That's why os.replace() was added.
Ah, that's probably a more serious blocker for adding it to upstream Python.
Not so for
Charles-François Natali added the comment:
The workaround would be to unlink the file first, and then try to
create it with O_EXCL. You have a short window where there's no file,
but that shouldn't be a problem in this specific case, and it would
work on Windows.
As for issue #17222, well, many
Changes by Barry A. Warsaw ba...@python.org:
--
nosy: +barry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13146
___
___
Python-bugs-list mailing
Changes by Christian Heimes li...@cheimes.de:
--
nosy: +christian.heimes
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13146
___
___
Brett Cannon br...@python.org added the comment:
And thanks for doing this, Antoine! One less thing on my never-ending
todo list. =)
On Mon, Oct 17, 2011 at 10:35, Antoine Pitrou rep...@bugs.python.org wrote:
Antoine Pitrou pit...@free.fr added the comment:
Should be fixed now. Thanks for
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset c16063765d3a by Antoine Pitrou in branch 'default':
Issue #13146: Writing a pyc file is now atomic under POSIX.
http://hg.python.org/cpython/rev/c16063765d3a
--
nosy: +python-dev
Antoine Pitrou pit...@free.fr added the comment:
Should be fixed now. Thanks for the reviews!
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Antoine Pitrou pit...@free.fr added the comment:
Ok, here is a new patch using O_EXCL.
Also, since import.c is quite different in 3.2, I'm not sure I will bother
backporting.
--
versions: -Python 3.2
Added file: http://bugs.python.org/file23396/importrename3.patch
Charles-François Natali neolo...@free.fr added the comment:
Here is a patch for import.c.
Looks good to me.
This new patch also fixes importlib.
path_tmp = path + '.tmp'
with _io.FileIO(path_tmp, 'wb') as file:
file.write(data)
Antoine Pitrou pit...@free.fr added the comment:
This new patch also fixes importlib.
path_tmp = path + '.tmp'
with _io.FileIO(path_tmp, 'wb') as file:
file.write(data)
_os.rename(path_tmp, path)
I don't know
Charles-François Natali neolo...@free.fr added the comment:
Or perhaps append the PID to the name of the temp file ?
(easier done in Python than in C :-))
I don't really like appending PIDs to generate file names:
- if you have multiple processes at the same time, they'll all write
their own
STINNER Victor victor.stin...@haypocalc.com added the comment:
with atomic_create(final path, 'b') as f:
See issues #8604 and #8828.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13146
Antoine Pitrou pit...@free.fr added the comment:
This new patch also fixes importlib.
--
stage: - patch review
versions: -Python 2.7
Added file: http://bugs.python.org/file23378/importrename2.patch
___
Python tracker rep...@bugs.python.org
STINNER Victor victor.stin...@haypocalc.com added the comment:
So if a process replaces the PYC file whereas another is reading the PYC, the
reader may read corrupted data? The ideal fix is maybe to use a file lock?
--
nosy: +haypo
___
Python
Antoine Pitrou pit...@free.fr added the comment:
So if a process replaces the PYC file whereas another is reading the
PYC, the reader may read corrupted data?
No, this is the whole point of the patch.
--
___
Python tracker rep...@bugs.python.org
New submission from Antoine Pitrou pit...@free.fr:
One of the buildbots recently showed the following failure:
==
ERROR: test_rapid_restart
(test.test_multiprocessing.WithProcessesTestManagerRestart)
Antoine Pitrou pit...@free.fr added the comment:
Here is a patch for import.c.
--
keywords: +patch
Added file: http://bugs.python.org/file23375/importrename.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13146
29 matches
Mail list logo
