Antoine Pitrou added the comment:
Thanks for the patch, Jessica. It seems to work under Windows here.
--
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13204
___
Roundup Robot added the comment:
New changeset 7052fdd90a11 by Antoine Pitrou in branch '3.4':
Issue #13204: Calling sys.flags.__new__ would crash the interpreter, now it
raises a TypeError.
http://hg.python.org/cpython/rev/7052fdd90a11
New changeset a14012352f65 by Antoine Pitrou in branch
Antoine Pitrou added the comment:
I've committed the patch to 3.4 and 3.5. I'm closing the issue, I don't think
fixing 2.7 is important at this point.
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker
Jessica McKellar added the comment:
Thanks for reporting this and providing a patch, Trundle.
The Python 3 patch didn't apply cleanly anymore, so I regenerated it and added
tests for sys.version_info and sys.getwindowsversion.
* The patch passes `make patchcheck`
* The full test suite passes
Antoine Pitrou pit...@free.fr added the comment:
Thanks for the patch. You should add the same tests for sys.version_info and
sys.getwindowsversion.
--
nosy: +pitrou
stage: - patch review
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
You are right. Even if it’s an undocumented internal type, there is no reason
not to fix it. There are plenty of similar crash fixes committed in the repo.
--
___
Python tracker
Éric Araujo mer...@netwok.org added the comment:
I’m not sure it is useful to fix this bug.
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13204
___
Ezio Melotti ezio.melo...@gmail.com added the comment:
Why not?
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13204
___
___
Éric Araujo mer...@netwok.org added the comment:
Because the class of sys.flags is an implementation detail. Most people won’t
try to instantiate it, IMO.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13204
Ezio Melotti ezio.melo...@gmail.com added the comment:
That's probably true, but IMHO it's not a valid reason to keep the buggy
behavior.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13204
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Why would we want to prevent users from creating new instances of FlagsType?
--
nosy: +amaury.forgeotdarc
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13204
New submission from Andreas Stührk andy-pyt...@hammerhartes.de:
It's not possible (by intention) to instantiate a new instance of sys.flags.
This is achieved by setting the tp_new slot to NULL (in `_PySys_Init()`),
after `PyType_Ready()` is called, which means that a slot wrapper is added to
Changes by Andreas Stührk andy-pyt...@hammerhartes.de:
Added file: http://bugs.python.org/file23432/sys_flags__new__crash_2.7.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13204
___
Changes by STINNER Victor victor.stin...@haypocalc.com:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13204
___
___
14 matches
Mail list logo