[issue13218] test_ssl failures on Debian/Ubuntu

2011-10-24 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- title: test_ssl failures on Ubuntu 11.10 -> test_ssl failures on Debian/Ubuntu ___ Python tracker ___

[issue13218] test_ssl failures on Debian/Ubuntu

2011-10-24 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: TL;DR: Let's rip out the false assumption that an SSLv23 client cannot connect to an SSLv3/TLSv1 server. I now believe this is simply an erroneous assumption on the part of the Python test suite, namely that SSLv23 method clients cannot connect to SSLv3 or T

[issue13218] test_ssl failures on Debian/Ubuntu

2011-10-25 Thread Antoine Pitrou
Antoine Pitrou added the comment: > It looks like it's been this way for a long time too. But tests have always passed here using OpenSSL 1.0.0. > It's probably too difficult, and not really Python's responsibility, > to determine whether SSL_OP_NO_SSLv2 is set. See http://docs.python.org/dev

[issue13218] test_ssl failures on Debian/Ubuntu

2011-10-25 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Oct 25, 2011, at 09:56 AM, Antoine Pitrou wrote: > >Antoine Pitrou added the comment: > >> It looks like it's been this way for a long time too. > >But tests have always passed here using OpenSSL 1.0.0. Right, sorry, what I meant was this particular behav

[issue13218] test_ssl failures on Debian/Ubuntu

2011-10-25 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I'm not sure I particularly like this patch, and I can't test it on anything other than Debian/Ubuntu right now, but it does "fix" the test (defined as: making it pass :). AFAICT, there's no way to tell openssl to revert back to trying SSLv2 client hello wh

[issue13218] test_ssl failures on Debian/Ubuntu

2011-10-25 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Here's the diff that disables SSLv2 and changes the expected sense of the connection results. Again, I can't test this on other than Debian/Ubuntu atm, so feedback would be useful. -- Added file: http://bugs.python.org/file23518/issue13218-true.diff

[issue13218] test_ssl failures on Debian/Ubuntu

2011-10-27 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On further reflection, I don't much like my second patch either. I don't think it'll be portable. I suggest just removing this test. -- ___ Python tracker

[issue13218] test_ssl failures on Debian/Ubuntu

2011-10-27 Thread Antoine Pitrou
Antoine Pitrou added the comment: For the record, both patches work fine here (Mageia 1, OpenSSL 1.0.0d). -- ___ Python tracker ___ _

[issue13218] test_ssl failures on Debian/Ubuntu

2011-10-27 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Oct 27, 2011, at 10:08 PM, Antoine Pitrou wrote: >Antoine Pitrou added the comment: > >For the record, both patches work fine here (Mageia 1, OpenSSL 1.0.0d). Cool. I'll try to verify them on OS X 10.6 (and maybe 10.7). If they work there I'll figure ou

[issue13218] test_ssl failures on Debian/Ubuntu

2011-10-28 Thread STINNER Victor
STINNER Victor added the comment: "./python -m test -v -u all test_ssl" pass with issue13218.diff or issue13218-true.diff on Ubuntu 10.10. -- ___ Python tracker ___ ___

[issue13218] test_ssl failures on Debian/Ubuntu

2011-10-28 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I can't test this on OS X 10.7 because of issue 13241 but it works fine on OS X 10.6. I'm going to go with the first diff (i.e. the non-sense changing version). I can't say why I favor that version but since you've both verified it works on !Ubuntu, we'll

[issue13218] test_ssl failures on Debian/Ubuntu

2011-10-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3c225f938dae by Barry Warsaw in branch '2.7': - Issue #13218: Fix test_ssl failures on Debian/Ubuntu. http://hg.python.org/cpython/rev/3c225f938dae New changeset 415e2c998e18 by Barry Warsaw in branch '3.2': - Issue #13218: Fix test_ssl failures on

[issue13218] test_ssl failures on Debian/Ubuntu

2011-10-28 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue13218] test_ssl failures on Debian/Ubuntu

2011-10-30 Thread Nadeem Vawda
Nadeem Vawda added the comment: > New changeset 3c225f938dae by Barry Warsaw in branch '2.7': > - Issue #13218: Fix test_ssl failures on Debian/Ubuntu. > http://hg.python.org/cpython/rev/3c225f938dae This changeset appears to have broken a number of the 2.7 Linux buildbots: http://www.pyt