Kostyantyn Leschenko added the comment:
I've updated patch to work with current trunk.
--
nosy: +Kostyantyn.Leschenko, asvetlov
versions: +Python 3.4 -Python 3.2
Added file: http://bugs.python.org/file29704/Issue13249-5.patch
___
Python tracker
Andrew Svetlov added the comment:
Fixed in 4712f9f8a90d, 5e5081cdc086, e4beda7cca2f.
Thanks.
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Mark Lawrence added the comment:
Can someone please review the latest patch and commit if appropriate.
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13249
___
Steven Bethard steven.beth...@gmail.com added the comment:
I've updated the patch for the current trunk. Should be ready to commit.
--
Added file: http://bugs.python.org/file26490/Issue13249-4.patch
___
Python tracker rep...@bugs.python.org
Steven Bethard steven.beth...@gmail.com added the comment:
The ArgumentParser constructor is definitely only intended to be called with
keyword arguments, so it's definitely a documentation bug that it doesn't say
this. I haven't actually applied the patch, but the basic approach and wording
Roy Smith r...@panix.com added the comment:
Another patch, with the most recent review suggestions incorporated.
--
Added file: http://bugs.python.org/file23703/Issue13249-3.patch
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
I would not use a note directive. Notes and warnings distract and sometimes
scare readers. For a simple coding recommendation like this, I think a regular
paragraph would suffice. To make sure it’s not lost after pages of options
Roy Smith r...@panix.com added the comment:
Before I build another patch, would you be OK with leaving it as a note, but
adding the due to the number of arguments language? There's a lot of text
here, and people tend to just zoom in on the bits and pieces they need right
now. I think there
Terry J. Reedy tjre...@udel.edu added the comment:
I agree with Eric both as to placement (first paragraph) and wording (with
explanation). I don't have time to review otherwise at the moment.
--
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
Thanks, I’ve made some comments on Rietveld.
Added a recommendation to only use keywords, which seems sane given
the number of arguments.
I looked for that but couldn’t find it.
--
nosy: +eric.araujo
Roy Smith r...@panix.com added the comment:
New patch uploaded.
The added recommendation is around line 161 (look for 'Recommended usage is to
only use keyword arguments')
--
Added file: http://bugs.python.org/file23667/Issue13249-2.patch
___
New submission from Roy Smith r...@panix.com:
The docs list the arguments in the order:
class argparse.ArgumentParser([description][, epilog][, prog]...
but the code (I'm looking at the 2.7.2 source) lists them as:
class ArgumentParser(_AttributeHolder, _ActionsContainer):
[...]
def
Florent Xicluna florent.xicl...@gmail.com added the comment:
in 3.x, same issue.
IMHO documentation should be fixed.
--
assignee: - docs@python
components: +Documentation
nosy: +bethard, docs@python, flox
stage: - needs patch
versions: +Python 3.2, Python 3.3
Petri Lehtinen pe...@digip.org added the comment:
Fixing the documentation is better, as changing the argument order would break
existing code.
--
keywords: +easy
nosy: +petri.lehtinen
___
Python tracker rep...@bugs.python.org
Changes by Santoso Wijaya santoso.wij...@gmail.com:
--
nosy: +santa4nt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13249
___
___
Terry J. Reedy tjre...@udel.edu added the comment:
In the doc, the signature line is followed by a list of short descriptions in a
third order. That perhaps should be changed to follow the same corrected order
as the signature line. On the other hand, it matches the order of the detail
Roy Smith r...@panix.com added the comment:
An Nth place is in the docstring:
Keyword Arguments:
- prog -- The name of the program (default: sys.argv[0])
-
Roy Smith r...@panix.com added the comment:
I'm working on a doc patch now...
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13249
___
___
Roy Smith r...@panix.com added the comment:
Patch attached. I just deal with putting all the items into the same order,
not terry.reedy's idea for separating them into two groups.
Added a recommendation to only use keywords, which seems sane given the number
of arguments.
--
Roy Smith r...@panix.com added the comment:
PS -- this is against the 2.7 branch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13249
___
___
20 matches
Mail list logo
