[issue13254] maildir.items() broken

Petri Lehtinen added the comment: Even better would be to set skewfactor to something negative in this test, too. I was told that long sleeps in tests are frowned upon. -- ___ Python tracker __

[issue13254] maildir.items() broken

Florent Xicluna added the comment: This is a transient failure, other builds are successful. Maybe the line "time.sleep(2.01 + self._box._skewfactor)" could be changed to "time.sleep(2.5 + self._box._skewfactor)" in test_mailbox.TestMaildir.test_reread. Closing because it's not related to th

[issue13254] maildir.items() broken

Florent Xicluna added the comment: test fails on x86 Windows7 2.7 buildbot (ok on 3.2 and 3.3) test_unix_mbox (test.test_mailbox.MaildirTestCase) ... D:\cygwin\home\db3l\buildarea\2.7.bolen-windows7\build\lib\sqlite3\test\dbapi.py:649: DeprecationWarning: buffer() not supported in 3.x b =

[issue13254] maildir.items() broken

Petri Lehtinen added the comment: In the absence of any complaints, I went on and committed the fix. Thanks for reporting the issue! -- assignee: r.david.murray -> ___ Python tracker

[issue13254] maildir.items() broken

Roundup Robot added the comment: New changeset 5f27a9f67a34 by Petri Lehtinen in branch '3.2': Fix Maildir initialization so that maildir contents are read correctly. http://hg.python.org/cpython/rev/5f27a9f67a34 New changeset 91a0f6879173 by Petri Lehtinen in branch 'default': Fix Maildir init

[issue13254] maildir.items() broken

Changes by Florent Xicluna : -- keywords: -needs review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue13254] maildir.items() broken

Changes by Florent Xicluna : Removed file: http://bugs.python.org/file23586/issue13254_v2.diff ___ Python tracker ___ ___ Python-bugs-list mai

[issue13254] maildir.items() broken

Petri Lehtinen added the comment: The last patch looks good to me and is a clever approach indeed :) -- ___ Python tracker ___ ___ Py

[issue13254] maildir.items() broken

Florent Xicluna added the comment: Finally, the patch can be only 5 lines... -- Added file: http://bugs.python.org/file23587/issue13254_v3.diff ___ Python tracker ___ __

[issue13254] maildir.items() broken

Changes by Florent Xicluna : Removed file: http://bugs.python.org/file23585/issue13254_v2.diff ___ Python tracker ___ ___ Python-bugs-list mai

[issue13254] maildir.items() broken

Florent Xicluna added the comment: Re-uploaded, because we can set initialize _last_read to 0 instead of time.time(). It is more consistent. -- Added file: http://bugs.python.org/file23586/issue13254_v2.diff ___ Python tracker

[issue13254] maildir.items() broken

Florent Xicluna added the comment: The patch by Petri looks good. I've uploaded a variant which set the initial mtimes to epoch instead of creating a _toc_read attribute. The tests are not changed. -- nosy: +flox Added file: http://bugs.python.org/file23585/issue13254_v2.diff

[issue13254] maildir.items() broken

Petri Lehtinen added the comment: Attached a patch. It makes _refresh() re-read the _toc uncoditionally when called the first time. -- keywords: +needs review, patch stage: needs patch -> patch review Added file: http://bugs.python.org/file23584/issue13254.patch __

[issue13254] maildir.items() broken

Petri Lehtinen added the comment: More specifically, this happens if the Maildir instance is created two seconds before items() is called: >>> import time >>> from mailbox import Maildir >>> x = Maildir('test') # has messages >>> time.sleep(2.5) >>> x.items() [] This happens because __init__

[issue13254] maildir.items() broken

R. David Murray added the comment: Since this is a regression I'm upping the priority further to release blocker, so that we don't put out another release with the regression still in it. -- nosy: +benjamin.peterson, georg.brandl priority: high -> release blocker _

[issue13254] maildir.items() broken

R. David Murray added the comment: I'm assigning this to myself so I don't lose it, but if someone wants to work on a patch please do. It'll be a bit before I can look at it. -- assignee: -> r.david.murray priority: normal -> high stage: -> needs patch _

[issue13254] maildir.items() broken

marco ghidinelli added the comment: 3.1 is ok 3.2.2 is affected -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue13254] maildir.items() broken

Changes by Petri Lehtinen : -- nosy: +petri.lehtinen ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue13254] maildir.items() broken

marco ghidinelli added the comment: i verified now, and the 2.7.1 version is ok, the bug is present since the 2.7.2 -- ___ Python tracker ___ ___

[issue13254] maildir.items() broken

Changes by Antoine Pitrou : -- nosy: +r.david.murray versions: +Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue13254] maildir.items() broken

New submission from marco ghidinelli : since python 2.7.2 maildir.items() doesn't return anything: >>> from mailbox import Maildir >>> x = Maildir('test') >>> x.items() [] untils something was written on the maildir. >>> x.add('bubu') '1319447613.M259111P6097Q1.deeppurple' >>> x.items() [('13