R. David Murray rdmur...@bitdance.com added the comment:
Committed Neil's patch (after adding docs) in r85671. Thanks.
--
nosy: +r.david.murray
resolution: - accepted
stage: patch review - committed/rejected
status: open - closed
___
Python tracker
Neil Muller drnlmuller+b...@gmail.com added the comment:
So what still needs to happen to get this in?
Patch still applies to current python 3.2 trunk (r85564).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1343
Éric Araujo mer...@netwok.org added the comment:
Patch looks good to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1343
___
___
Mark Lawrence breamore...@yahoo.co.uk added the comment:
Can a committer look at this please.
--
stage: commit review - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1343
___
Neil Muller drnlmuller+b...@gmail.com added the comment:
Updated version of the patch against current py3k svn (r83022) attached.
This is a combined patch, including the previous xml.sax.saxutil changes
(including the 'short_empty_elements' keyword) and the new tests.
--
nosy: +Neil
Mark Lawrence breamore...@yahoo.co.uk added the comment:
The patch looks clean to me, applied small edits to change it from git to svn.
Changed test_sax got 7 errors on run. Changed saxutils 53 tests all passed.
Can this please be committed.
--
stage: patch review - commit review
Mark Lawrence breamore...@yahoo.co.uk added the comment:
I believe 3.2 is still open for new features.
--
nosy: +BreamoreBoy
versions: +Python 3.2 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1343
Ken Ganong ken.gan...@gmail.com added the comment:
This bug is tagged as easy and appears to already have a patch and a test
posted from two years ago. What is still to be done here?
--
nosy: +ken.ganong
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
I added the “needs review” keyword, to make this easy to find for reviewers,
changed the version (new features don’t go in older versions; check if your
patches still apply), and added MvL as nosy, since he’s listed as expert for
the xml
Jonathan Hitchcock [EMAIL PROTECTED] added the comment:
The attached patch makes this new feature optional, by passing the
empty_element_tag option to the constructor.
--
nosy: +vhata
Added file: http://bugs.python.org/file10261/xml.sax.saxutils.patch
__
Jonathan Hitchcock [EMAIL PROTECTED] added the comment:
I have also added some unit tests to test the feature with the option
turned on, and off - patch attached.
Added file: http://bugs.python.org/file10262/test.test_sax.py.patch
__
Tracker [EMAIL PROTECTED]
Jonathan Hitchcock [EMAIL PROTECTED] added the comment:
Acting on a comment (with which I agree) that the empty_elements_tag
wasn't such an obvious name, here's a (combined) patch which uses the
name short_empty_elements (which was my original gut-feeling idea for
the name, before I checked the
Changes by Christian Heimes:
--
keywords: +easy, patch
priority: - normal
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1343
__
___
Python-bugs-list mailing list
Gabriel Genellina added the comment:
Some (ugly) parsers insist on container/
container when the element is not declared to
be empty, so this should be optional (the
default being generate container/)
--
nosy: +gagenellina
__
Tracker [EMAIL PROTECTED]
panzi added the comment:
patch for xml/sax/saxutils.py
Added file: http://bugs.python.org/file8631/xml.sax.saxutils.patch
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1343
__--- /usr/lib/python2.5/xml/sax/saxutils.py
panzi added the comment:
patch for _xmlplus.sax.saxutils.py
Added file: http://bugs.python.org/file8632/_xmlplus.sax.saxutils.patch
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1343
__---
16 matches
Mail list logo
