[issue13447] Add tests for some scripts in Tools/scripts

Éric Araujo added the comment: > I meant "Test for Tools" instead of """Tests for reindent.py.""" Looks like you missed the message where I wrote how I changed s/reindent.py/scripts in the Tools directory/ Committed! Now we can tackle all these nasty pygettext and msgfmt bugs, and I will al

[issue13447] Add tests for some scripts in Tools/scripts

Roundup Robot added the comment: New changeset 2887f5a97075 by Éric Araujo in branch '3.2': Add test file for scripts in Tools (#13447). http://hg.python.org/cpython/rev/2887f5a97075 -- ___ Python tracker

[issue13447] Add tests for some scripts in Tools/scripts

Éric Araujo added the comment: Hi Mark. You’re the author of Tools/parser/test_unparse.py; any objection if I move it to the new Lib/test/test_tools.py file, so that all tests for Tools are in one place? -- nosy: +mark.dickinson ___ Python tracker

[issue13447] Add tests for some scripts in Tools/scripts

Roundup Robot added the comment: New changeset 020364d3e359 by Éric Araujo in branch '2.7': Add test file for scripts in Tools (#13447). http://hg.python.org/cpython/rev/020364d3e359 -- nosy: +python-dev ___ Python tracker

[issue13447] Add tests for some scripts in Tools/scripts

Francisco Martín Brugué added the comment: Sorry, my fault: I meant "Test for Tools" instead of """Tests for reindent.py.""" (Im not talking about the skip message but the test documentation or the first line 0,0...) -- ___ Python tracker

[issue13447] Add tests for some scripts in Tools/scripts

Éric Araujo added the comment: > if test_tools is going to be the test for all the Tools (at least until it > grows to much), Seriously, we don’t care about the size of test files. test_argparse.py is 4777 lines long :) > shoudn't be be module doc something like “””Tests for scripts in Tools

[issue13447] Add tests for some scripts in Tools/scripts

Nadeem Vawda added the comment: [Éric] > New docstring: > > Tests for scripts in the Tools directory. > > This file contains regression tests for some of the scripts found in the > Tools directory of a Python checkout or tarball, such as reindent.py. > > When I commit I’ll also send to pyt

[issue13447] Add tests for some scripts in Tools/scripts

Francisco Martín Brugué added the comment: Hi Éric, some questions: 1)if test_tools is going to be the test for all the Tools (at least until it grows to much), shoudn't be be module doc something like “””Tests for scripts in Tools/**“”” 2)is the SkipTest “reindent” specific? Cheers, franc

[issue13447] Add tests for some scripts in Tools/scripts

Éric Araujo added the comment: Good points. New docstring: Tests for scripts in the Tools directory. This file contains regression tests for some of the scripts found in the Tools directory of a Python checkout or tarball, such as reindent.py. When I commit I’ll also send to python-dev

[issue13447] Add tests for some scripts in Tools/scripts

Nadeem Vawda added the comment: > Shall I commit the new file or first add more tests? Might as well commit now; there's no sense in leaving the code sitting around just because the file feels a bit short. A couple of minor nits about your patch, though: - The docstring for test_tools says "T

[issue13447] Add tests for some scripts in Tools/scripts

Éric Araujo added the comment: Shall I commit the new file or first add more tests? > I don't think it's a big deal, eventually people will learn that it's there > and we can always > point to that file when a new issue is opened or during the patch review. Good. > Adding a check to `make pat

[issue13447] Add tests for some scripts in Tools/scripts

Ezio Melotti added the comment: > I went for something even simpler: one new file Lib/test/test_tools.py. I'm fine with this option too; if it grows too big we can always split it in several modules later. > My only concern is communication: how do we tell people working on a > tool that they

[issue13447] Add tests for some scripts in Tools/scripts

Éric Araujo added the comment: Nice idea, but 1) not everyone uses patchcheck 2) patchcheck comes after you’ve fixed something, but tests should be written before fixes (to reproduce the error) :) -- ___ Python tracker

[issue13447] Add tests for some scripts in Tools/scripts

Francisco Martín Brugué added the comment: > My only concern is communication: how do we tell people working on a tool > that they should write a test in test_tools? I’m not sure they would read > Tools/README; maybe a note at the top of the Python files would work; a note > in the devguide;

[issue13447] Add tests for some scripts in Tools/scripts

Changes by Eric Snow : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue13447] Add tests for some scripts in Tools/scripts

Éric Araujo added the comment: I went for something even simpler: one new file Lib/test/test_tools.py. There is no need to have a file there and more files in Tools/tests, everything can go in test_tools (I’m not worried about file size, we already have a few thousand-liners test modules).

[issue13447] Add tests for some scripts in Tools/scripts

Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue13447] Add tests for some scripts in Tools/scripts

Changes by Nadeem Vawda : -- nosy: +nadeem.vawda ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue13447] Add tests for some scripts in Tools/scripts

Éric Araujo added the comment: I’m pushing this higher on my todo list then. I’ll certainly upload a patch for review here with the basic machinery, then commit it, and then we’ll be able to add tests for the tools we like. -- assignee: -> eric.araujo __

[issue13447] Add tests for some scripts in Tools/scripts

Francisco Martín Brugué added the comment: +1 while working on #issue14053 I missed the test for the scripts (in this case some kind of mocking is needed). -- ___ Python tracker _

[issue13447] Add tests for some scripts in Tools/scripts

Changes by Ezio Melotti : -- nosy: +francismb type: -> enhancement ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue13447] Add tests for some scripts in Tools/scripts

Changes by Éric Araujo : -- title: Add tests for Tools/scripts/reindent.py -> Add tests for some scripts in Tools/scripts ___ Python tracker ___