[issue13550] Rewrite logging hack of the threading module

Roundup Robot added the comment: New changeset 8ec51b2e57c2 by Victor Stinner in branch 'default': Close #13550: Remove the debug machinery from the threading module: remove http://hg.python.org/cpython/rev/8ec51b2e57c2 -- nosy: +python-dev resolution: -> fixed stage: -> committed/rej

[issue13550] Rewrite logging hack of the threading module

Nick Coghlan added the comment: I believe Charles-François was referring to this message: http://mail.python.org/pipermail/python-dev/2012-January/115372.html We shouldn't be encumbering threading *all the time* with stuff that "might be useful sometimes". Adding selective output to help debug

[issue13550] Rewrite logging hack of the threading module

STINNER Victor added the comment: > Alright, Nick agreed on python-dev to remove the logging hack. You mean removing complelty debug logging from the threading module? Or just to simplify the code to decide if we should log or not? -- ___ Python tr

[issue13550] Rewrite logging hack of the threading module

Éric Araujo added the comment: haypo’s threading_note_global looks good to me. The only thing I’m not sure about is the signature change from X(verbose, *args, **kwargs) to X(*args, **kwargs): is it okay? (BTW you probably want to delete the obsolete reference to ihooks in a comment before

[issue13550] Rewrite logging hack of the threading module

Charles-François Natali added the comment: Alright, Nick agreed on python-dev to remove the logging hack. -- nosy: +ncoghlan ___ Python tracker ___ _

[issue13550] Rewrite logging hack of the threading module

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue13550] Rewrite logging hack of the threading module

Charles-François Natali added the comment: I'm personally +1 on removing the verbose thing altogether: - it's ugly - I doubt it's really useful (I mean, printing to stderr - which is often line buffered or unbuffered - upon every action will probably change the timing) - it also brings some pro

[issue13550] Rewrite logging hack of the threading module

Éric Araujo added the comment: On #13550 I asked Guido about the Thing/_Thing function/class indirection and use of _Verbose; the reply: > IIRC: > > The design started out this way because it predates new-style classes. When > this was put in one > couldn't subclass extension types, and the

[issue13550] Rewrite logging hack of the threading module

Antoine Pitrou added the comment: Tim, do you happen to know what the goal was with the threading._VERBOSE hack and the undocumented _Verbose class? -- nosy: +pitrou, tim_one ___ Python tracker __

[issue13550] Rewrite logging hack of the threading module

STINNER Victor added the comment: (threading_note_global.patch was completly wrong, here is the fixed version) -- Added file: http://bugs.python.org/file23871/threading_note_global.patch ___ Python tracker ___

[issue13550] Rewrite logging hack of the threading module

Changes by STINNER Victor : Removed file: http://bugs.python.org/file23870/threading_note_global.patch ___ Python tracker ___ ___ Python-bugs-

[issue13550] Rewrite logging hack of the threading module

Changes by STINNER Victor : Added file: http://bugs.python.org/file23870/threading_note_global.patch ___ Python tracker ___ ___ Python-bugs-li

[issue13550] Rewrite logging hack of the threading module

New submission from STINNER Victor : The threading module uses an hack to log actions to help debugging. The log depends on 3 flags: __debug__, threading._VERBOSE and a verbose attribute (each threading class has such attribute). By default, _note() is always called but does nothing: it checks