[issue13637] binascii.a2b_* functions could accept unicode strings

R. David Murray added the comment: Ah, yes, I see. Sorry for the confusion, I misread that part of the discussion and did not look at that part of the docs. (I find that note confusing...it seems to imply that a2b only accepts ascii. But that's a different issue and I don't feel strongly eno

[issue13637] binascii.a2b_* functions could accept unicode strings

Martin Panter added the comment: If I understand what you are saying, you don’t mind not mentioning 3.1 behaviour, but want to mention 3.2 behaviour. Perhaps the existing “Note” box at the top of the page is good enough for you, as pointed out in .

[issue13637] binascii.a2b_* functions could accept unicode strings

R. David Murray added the comment: I think this doc change was incorrect. The current document is supposed to provide the correct historical information. So "changed in 3.3: accept ASCII input" (and just ignore the fact that 3.1 also accepted ascii, since we pretty much prefer to ignore the

[issue13637] binascii.a2b_* functions could accept unicode strings

Berker Peksag added the comment: Thank you to both Vajrasky and Martin. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___

[issue13637] binascii.a2b_* functions could accept unicode strings

Roundup Robot added the comment: New changeset ad4a8176a71a by Berker Peksag in branch '3.4': Issue #13637: Improve exception message of a2b_* functions. https://hg.python.org/cpython/rev/ad4a8176a71a New changeset 55f5e960cc40 by Berker Peksag in branch 'default': Issue #13637: Improve exceptio

[issue13637] binascii.a2b_* functions could accept unicode strings

Roundup Robot added the comment: New changeset 8d32453dd0f7 by Berker Peksag in branch '3.4': Issue #13637: Remove outdated versionchanged directives. https://hg.python.org/cpython/rev/8d32453dd0f7 New changeset d3ca674cf716 by Berker Peksag in branch 'default': Issue #13637: Remove outdated ver

[issue13637] binascii.a2b_* functions could accept unicode strings

Martin Panter added the comment: That’s another option. Someone might wonder why a2b_hex() and a2b_qp() actually accept text strings in Python 3.1 when the documentation says you need 3.3, but I guess that’s not such a big deal. Posting patch v3 which removes the 3.2 notices. -- Added

[issue13637] binascii.a2b_* functions could accept unicode strings

Berker Peksag added the comment: The binascii documentation already says ``a2b_*`` functions accept Unicode strings containing only ASCII characters. [...] .. versionchanged:: 3.3 ASCII-only unicode strings are now accepted by the ``a2b_*`` functions. I think we can just remove

[issue13637] binascii.a2b_* functions could accept unicode strings

Martin Panter added the comment: The error fix patch looks good. I updated the doc patch as fix_doc_binascii_unhexlify.v2.patch, which also clarifies a2b_qp(), and restores the description of Python 3.2 not allowing text strings. -- assignee: -> docs@python components: +Documentation

[issue13637] binascii.a2b_* functions could accept unicode strings

Martin Panter added the comment: The a2b_qp() function also documents a byte string restriction for 3.2, and now 3.3 also seems to support ASCII-compatible text strings. Maybe the documentation should reflect this also? -- nosy: +vadmium ___ Python

[issue13637] binascii.a2b_* functions could accept unicode strings

Vajrasky Kok added the comment: Here is another patch to better the error message. Right now, the error message when wrong input sent to unhexlify is a little bit funny. >>> import binascii >>> binascii.unhexlify(3) Traceback (most recent call last): File "", line 1, in TypeError: argument s

[issue13637] binascii.a2b_* functions could accept unicode strings

Vajrasky Kok added the comment: Antoine, I think you forgot to update the doc. http://docs.python.org/3.4/library/binascii.html#binascii.unhexlify Changed in version 3.2: Accept only bytestring or bytearray objects as input. Attached the patch to update the doc to reflect the changes in this t

[issue13637] binascii.a2b_* functions could accept unicode strings

Arfrever Frehtes Taifersar Arahesis added the comment: I confirm that it works in Python 3.1 and doesn't work in Python 3.2. -- nosy: +Arfrever resolution: fixed -> stage: committed/rejected -> status: closed -> open type: enhancement -> behavior _

[issue13637] binascii.a2b_* functions could accept unicode strings

Luke-Jr added the comment: Has this been fixed in 3.2 yet? Somehow it seems to have been "reclassified" as an enhancement when it's really a regression. str worked fine in these functions in 3.1. -- nosy: +luke-jr ___ Python tracker

[issue13637] binascii.a2b_* functions could accept unicode strings

R. David Murray added the comment: Discussion resolved in favor of patch. -- status: open -> closed ___ Python tracker ___ ___ Python

[issue13637] binascii.a2b_* functions could accept unicode strings

R. David Murray added the comment: I disagree with this feature. Reopening pending discussion on python-dev. -- nosy: +r.david.murray status: closed -> open ___ Python tracker

[issue13637] binascii.a2b_* functions could accept unicode strings

Changes by Antoine Pitrou : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue13637] binascii.a2b_* functions could accept unicode strings

Antoine Pitrou added the comment: Committed now. -- resolution: -> fixed stage: patch review -> committed/rejected ___ Python tracker ___ __

[issue13637] binascii.a2b_* functions could accept unicode strings

Roundup Robot added the comment: New changeset eb8d62706d5f by Antoine Pitrou in branch 'default': Issue #13637: "a2b" functions in the binascii module now accept ASCII-only unicode strings. http://hg.python.org/cpython/rev/eb8d62706d5f -- nosy: +python-dev ___

[issue13637] binascii.a2b_* functions could accept unicode strings

Antoine Pitrou added the comment: Here is a patch. -- keywords: +patch stage: needs patch -> patch review Added file: http://bugs.python.org/file24060/binasciistr.patch ___ Python tracker _

[issue13637] binascii.a2b_* functions could accept unicode strings

New submission from Antoine Pitrou : a2b_hex and friends accept only byte strings: >>> binascii.a2b_hex(b'00') b'\x00' >>> binascii.a2b_hex('00') Traceback (most recent call last): File "", line 1, in TypeError: 'str' does not support the buffer interface But they could just as well accept A