[issue13842] Cannot pickle Ellipsis or NotImplemented

2012-03-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5353357382e2 by Łukasz Langa in branch 'default': #13842: check whether PyUnicode_FromString succeeded http://hg.python.org/cpython/rev/5353357382e2 -- ___ Python tracker

[issue13842] Cannot pickle Ellipsis or NotImplemented

2012-03-12 Thread Łukasz Langa
Changes by Łukasz Langa : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue13842] Cannot pickle Ellipsis or NotImplemented

2012-03-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5832d3622473 by Łukasz Langa in branch 'default': Fixes #13842: cannot pickle Ellipsis or NotImplemented. http://hg.python.org/cpython/rev/5832d3622473 -- nosy: +python-dev ___ Python tracker

[issue13842] Cannot pickle Ellipsis or NotImplemented

2012-03-12 Thread Łukasz Langa
Łukasz Langa added the comment: There is indeed a 5% performance gain from using PyUnicode_FromString instead of the generic Py_BuildValue function. -- ___ Python tracker ___ _

[issue13842] Cannot pickle Ellipsis or NotImplemented

2012-03-08 Thread Łukasz Langa
Changes by Łukasz Langa : -- assignee: -> lukasz.langa nosy: +lukasz.langa ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue13842] Cannot pickle Ellipsis or NotImplemented

2012-02-19 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I'm completely new to the C API so not sure if the way I am building > python strings (to pass to save_global) is correct It's correct but it's probably less efficient than calling a more specialized function, such as PyUnicode_FromString(): http://docs.pyth

[issue13842] Cannot pickle Ellipsis or NotImplemented

2012-02-19 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +hynek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue13842] Cannot pickle Ellipsis or NotImplemented

2012-02-19 Thread Antoine Pitrou
Antoine Pitrou added the comment: I haven't taken a look at the patch in detail, but it lacks some tests. Pickling tests are generally in Lib/test/pickletester.py, they are invoked by test_pickle and test_pickletools. -- stage: needs patch -> patch review _

[issue13842] Cannot pickle Ellipsis or NotImplemented

2012-01-24 Thread James Sanders
James Sanders added the comment: I've submitted a patch that just uses save_global to pickle Ellipsis and NotImplemented, so the resulting pickle should be unpicklable anywhere. I'm completely new to the C API so not sure if the way I am building python strings (to pass to save_global) is co

[issue13842] Cannot pickle Ellipsis or NotImplemented

2012-01-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: > We will need to bump the protocol number to add support for None, > Ellipsis, and NotImplemented. Antoine, can you add this to PEP 3154? I don't think this needs a protocol bump. These are global singletons, they can be pickled as such, and they will be unpic

[issue13842] Cannot pickle Ellipsis or NotImplemented

2012-01-23 Thread Alexandre Vassalotti
Alexandre Vassalotti added the comment: We will need to bump the protocol number to add support for None, Ellipsis, and NotImplemented. Antoine, can you add this to PEP 3154? -- ___ Python tracker ___

[issue13842] Cannot pickle Ellipsis or NotImplemented

2012-01-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: I think it's a reasonable feature request. Now someone has to write a patch for it. -- stage: -> needs patch ___ Python tracker ___ _

[issue13842] Cannot pickle Ellipsis or NotImplemented

2012-01-23 Thread James Sanders
New submission from James Sanders : At present, the built-in constants Ellipsis (...) and NotImplemented cannot be pickled. Perhaps there is a good reason for this, but the only discussion I can find is at msg<108957>, where it is stated that these values (along with their types, and type(Non