[issue13897] Move fields relevant to sys.exc_info out of frame into generator/threadstate

Change by Serhiy Storchaka : -- status: open -> closed ___ Python tracker ___

[issue13897] Move fields relevant to sys.exc_info out of frame into generator/threadstate

Mark Shannon added the comment: Nothing left to do. This is now obsolete. -- resolution: -> out of date stage: patch review -> resolved status: pending -> open ___ Python tracker

[issue13897] Move fields relevant to sys.exc_info out of frame into generator/threadstate

Serhiy Storchaka added the comment: Aren't they were moved in issue25612? Is there something that should be done in this issue? -- nosy: +serhiy.storchaka ___ Python tracker

[issue13897] Move fields relevant to sys.exc_info out of frame into generator/threadstate

Change by Serhiy Storchaka : -- status: open -> pending ___ Python tracker ___

[issue13897] Move fields relevant to sys.exc_info out of frame into generator/threadstate

Mark Shannon added the comment: This issue is rather old, so I will create a new GitHub PR for the code change. This issue can be closed. Note that https://bugs.python.org/issue25612 is a manifestation of the problem that this was intended to solve. -- nosy: +Mark Shannon

[issue13897] Move fields relevant to sys.exc_info out of frame into generator/threadstate

Mark Shannon added the comment: Updated patch to support exception chaining and to merge cleanly. -- versions: +Python 3.6 -Python 3.4 Added file: http://bugs.python.org/file40015/exc_info3.patch ___ Python tracker rep...@bugs.python.org

[issue13897] Move fields relevant to sys.exc_info out of frame into generator/threadstate

Changes by Terry J. Reedy tjre...@udel.edu: -- versions: +Python 3.4 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13897 ___ ___

[issue13897] Move fields relevant to sys.exc_info out of frame into generator/threadstate

Stefan Behnel sco...@users.sourceforge.net added the comment: As long as there is a way to access these fields directly from the struct (with the usual preprocessor conditional), I don't think Cython will actually start to use the PyErr_[GS]etExcInfo() functions in CPython - simply for

[issue13897] Move fields relevant to sys.exc_info out of frame into generator/threadstate

Mark Shannon m...@hotpy.org added the comment: According to PEP 384 (Defining a Stable ABI) the thread state object is opaque, so we should be free to add or remove fields. Nevertheless, I have added a new patch that simply moves the f_exc... fields from the frame object to the generator. It

[issue13897] Move fields relevant to sys.exc_info out of frame into generator/threadstate

Antoine Pitrou pit...@free.fr added the comment: According to PEP 384 (Defining a Stable ABI) the thread state object is opaque, so we should be free to add or remove fields. Mmh, be aware the stable ABI is only a restricted part of the official API. There are APIs which are not part of the

[issue13897] Move fields relevant to sys.exc_info out of frame into generator/threadstate

Antoine Pitrou pit...@free.fr added the comment: This looks rather good on the principle. I think PyExcState needn't be public, it should be _PyExcState. I haven't checked the detailed mechanics of the patch, I hope someone else can. -- nosy: +pitrou

[issue13897] Move fields relevant to sys.exc_info out of frame into generator/threadstate

Stefan Behnel sco...@users.sourceforge.net added the comment: FWIW, Cython keeps the exception state in the generator struct and that works nicely. Note that Amaury is right in that extensions use tstate-exc_value and friends. Cython does so quite extensively, for example. I don't see any use

[issue13897] Move fields relevant to sys.exc_info out of frame into generator/threadstate

Antoine Pitrou pit...@free.fr added the comment: Note that Amaury is right in that extensions use tstate-exc_value and friends. Cython does so quite extensively, for example. I understand for Cython, but why would pedestrian extension code look up tstate-exc_value? --

[issue13897] Move fields relevant to sys.exc_info out of frame into generator/threadstate

Mark Shannon m...@hotpy.org added the comment: 3rd party code should not be accessing fields in the threadstate object, but without the accessors proposed in issue 14098 there may be no alternative. Once the patch for issue 14098 has been applied it, would it then be acceptable to remove the

[issue13897] Move fields relevant to sys.exc_info out of frame into generator/threadstate

Stefan Behnel sco...@users.sourceforge.net added the comment: I can't speak for much outside of Cython, and Cython generated modules would best be regenerated with a newer Cython version anyway in order to work with Py3.3. I'm not sure that's currently required, though. As long as there is a

[issue13897] Move fields relevant to sys.exc_info out of frame into generator/threadstate

Antoine Pitrou pit...@free.fr added the comment: As long as there is a way to access these fields directly from the struct (with the usual preprocessor conditional), I don't think Cython will actually start to use the PyErr_[GS]etExcInfo() functions in CPython - simply for performance

[issue13897] Move fields relevant to sys.exc_info out of frame into generator/threadstate

Mark Shannon m...@hotpy.org added the comment: Jim Jewett wrote: http://bugs.python.org/review/13897/diff/4186/14521 File Python/sysmodule.c (right): http://bugs.python.org/review/13897/diff/4186/14521#newcode211 Python/sysmodule.c:211: while ((exc_info-exc_type == NULL ||

[issue13897] Move fields relevant to sys.exc_info out of frame into generator/threadstate

Jim Jewett jimjjew...@gmail.com added the comment: I think the latest patch is indeed cleaner. -- nosy: +Jim.Jewett ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13897 ___

[issue13897] Move fields relevant to sys.exc_info out of frame into generator/threadstate

Mark Shannon m...@hotpy.org added the comment: This issue was too broad. The new patch is focussed on sys.exc_info. All hints of coroutines have been removed and f_yieldfrom is untouched. New patch reduces code by 65 lines and does not conflict with issue 13607. -- title: Move fields

[issue13897] Move fields relevant to sys.exc_info out of frame into generator/threadstate

Changes by Mark Shannon m...@hotpy.org: Removed file: http://bugs.python.org/file24350/coro.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13897 ___