[issue13953] Get rid of doctests in packaging.tests.test_version

Changes by Éric Araujo : -- resolution: -> out of date stage: -> committed/rejected status: open -> closed ___ Python tracker ___ __

[issue13953] Get rid of doctests in packaging.tests.test_version

Éric Araujo added the comment: > Does a "doc test" test the output literally? Yes, that’s the problem. See doctest documentation for more info about how it works and what problems it has. -- ___ Python tracker _

[issue13953] Get rid of doctests in packaging.tests.test_version

Francisco Martín Brugué added the comment: Does a "doc test" test the output literally? (I've just always used unittest) Ok, thanks -- ___ Python tracker ___ _

[issue13953] Get rid of doctests in packaging.tests.test_version

Éric Araujo added the comment: > Isn't that what the previous code (doctest code) did? I don’t understand, could you rephrase? > I thought that the code should be ported as far backwards as possible and > that's why I > used the plain assertEqual (I don't know exactly in with version the other

[issue13953] Get rid of doctests in packaging.tests.test_version

Francisco Martín Brugué added the comment: Thank you for the review. Just some questions: Isn't that what the previous code (doctest code) did? I thought that the code should be ported as far backwards as possible and that's why I used the plain assertEqual (I don't know exactly in with vers

[issue13953] Get rid of doctests in packaging.tests.test_version

Éric Araujo added the comment: Thanks, I’ve got it from that point. Notes for future patches: - Tests should not check the exact contents of error messages, as they are not part of the language - Don’t use assertEqual(..., True) but assertTrue, or if you’re testing comparisons, use assertGrea

[issue13953] Get rid of doctests in packaging.tests.test_version

Francisco Martín Brugué added the comment: I've done some cleanups -- Added file: http://bugs.python.org/file24471/issue13953_bf6f306ad5cf.patch ___ Python tracker ___ _

[issue13953] Get rid of doctests in packaging.tests.test_version

Francisco Martín Brugué added the comment: Hi here's a patch preview: it has to be re factored further but I stopped here as some tests failed: the out commented ones ... I've checked twice but I cannot see any diff, could you check that? Or, has maybe the behavior (due that bug) changed and

[issue13953] Get rid of doctests in packaging.tests.test_version

Éric Araujo added the comment: The interesting line is just after the string: doctest.script_from_examples(comparison_doctest_string) However it looks like there has been a problem with that line, as you can’t get the test to fail, which is strange as I did use that doctest to check #11841!