[issue14012] Misc tarfile fixes

2014-10-09 Thread R. David Murray
R. David Murray added the comment: The patch no longer applies again. -- assignee: lars.gustaebel -> nosy: +r.david.murray stage: commit review -> needs patch ___ Python tracker ___

[issue14012] Misc tarfile fixes

2013-08-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Lets push it. Lars? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue14012] Misc tarfile fixes

2013-08-13 Thread Éric Araujo
Éric Araujo added the comment: Thanks, LGTM. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue14012] Misc tarfile fixes

2013-08-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is updated for 3.4 patch. -- Added file: http://bugs.python.org/file31146/tarfile-misc-bugs-3.4.diff ___ Python tracker ___ _

[issue14012] Misc tarfile fixes

2013-04-14 Thread Éric Araujo
Éric Araujo added the comment: I should be able to do that but can’t say when. -- versions: -Python 3.2 ___ Python tracker ___ ___ Py

[issue14012] Misc tarfile fixes

2013-04-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Éric, can you please update your patch? -- ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue14012] Misc tarfile fixes

2013-02-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The patch is desynchronized from current sources. -- nosy: +serhiy.storchaka versions: +Python 3.4 ___ Python tracker ___

[issue14012] Misc tarfile fixes

2012-02-22 Thread Éric Araujo
Éric Araujo added the comment: > I removed the "import as" bit completely and changed all occurrences of > _open() to > builtins.open() which is more readable and explanatory. Truly. tokenize got a similar fix in ea260d393cde (without a test, so I think that here we don’t need one either); lo

[issue14012] Misc tarfile fixes

2012-02-22 Thread Lars Gustäbel
Lars Gustäbel added the comment: I updated your patch: - I removed the "import as" bit completely and changed all occurrences of _open() to builtins.open() which is more readable and explanatory. - I object to changing the error messages in the 3.2 branch due to backwards compatibility, alth

[issue14012] Misc tarfile fixes

2012-02-19 Thread Éric Araujo
Éric Araujo added the comment: Another one: now that shutil provides archiving operations, there is a circular dependency between tarfile and shutil. It does not cause problems*, as both modules use qualified names, but it may be a good thing to avoid import cascades for performance reasons.

[issue14012] Misc tarfile fixes

2012-02-18 Thread Lars Gustäbel
Changes by Lars Gustäbel : -- assignee: -> lars.gustaebel ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue14012] Misc tarfile fixes

2012-02-14 Thread Éric Araujo
New submission from Éric Araujo : I found a few possible bugs in tarfile: - “mode in 'raw'” can give false positives for '' or 'ra'. Most of the code also checks for “len(mode) > 1”, but I find clearer and safer to just use “mode in ('r', 'a', 'w')”. - To use the shadowed builtin “open”, tar