[issue14231] Fix or drop Lib/test/crashers/borrowed_ref_1.py

2012-03-09 Thread Armin Rigo
Armin Rigo added the comment: I will attempt a last time to mention that the docstrings in borrowed_ref_*.py used to say they were *examples*. That means: (1) find any internal or external C function that returns a borrowed reference; (2) find all callers and write down all the places that d

[issue14231] Fix or drop Lib/test/crashers/borrowed_ref_1.py

2012-03-09 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue14231] Fix or drop Lib/test/crashers/borrowed_ref_1.py

2012-03-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 850d7f6af1b0 by Victor Stinner in branch 'default': Issue #14231: Lib/test/crashers/borrowed_ref_1.py was fixed by ba6376dff6c4. http://hg.python.org/cpython/rev/850d7f6af1b0 -- nosy: +python-dev ___ Pyt

[issue14231] Fix or drop Lib/test/crashers/borrowed_ref_1.py

2012-03-09 Thread STINNER Victor
STINNER Victor added the comment: ba6376dff6c4 changed dict_subscript(): _PyType_Lookup() is replaced by _PyObject_LookupSpecial(). 7b4b921f3335 fixed a reference introduced in this change. _PyObject_Lookup() returns a borrowed reference, whereas _PyObject_LookupSpecial() increments the refe

[issue14231] Fix or drop Lib/test/crashers/borrowed_ref_1.py

2012-03-08 Thread STINNER Victor
STINNER Victor added the comment: Oh, it looks like the following commit fixed the issue without touching to the crasher test: ba6376dff6c4. Armin, Benjamin: can you confirm? -- nosy: +benjamin.peterson ___ Python tracker

[issue14231] Fix or drop Lib/test/crashers/borrowed_ref_1.py

2012-03-08 Thread Armin Rigo
Armin Rigo added the comment: Crashes for me on Python 2.5 and 2.6, but no longer on Python 2.7. The problem may have been fixed in the meantime. -- ___ Python tracker ___ ___

[issue14231] Fix or drop Lib/test/crashers/borrowed_ref_1.py

2012-03-08 Thread STINNER Victor
New submission from STINNER Victor : Lib/test/crashers/borrowed_ref_1.py contains the docstring: "_PyType_Lookup() returns a borrowed reference. This attacks the call in dictobject.c." The file was added by Armin in 2006 by the changeset 4dd1a9383e47. I just fixed #14211 which was a similar bug