[issue14300] dup_socket() on Windows should use WSA_FLAG_OVERLAPPED

2012-04-01 Thread Kristján Valur Jónsson
Kristján Valur Jónsson added the comment: Also, see this: http://support.microsoft.com/kb/179942/EN-US applies to windows 2000 only, as far as I can tell, though. Don't know if we still support that. I have scoured the docs, but found yet no reason to _not_ use this attribute. I wonder why

[issue14300] dup_socket() on Windows should use WSA_FLAG_OVERLAPPED

2012-04-01 Thread Kristján Valur Jónsson
Kristján Valur Jónsson added the comment: I already included this fix in my "socket share" patch, see issue 14310. I think this was a bug that should be checked in to all relevant branches. The reason is this text from msdn documentation for WsaDuplicateSocket: " Both the source process and t

[issue14300] dup_socket() on Windows should use WSA_FLAG_OVERLAPPED

2012-03-31 Thread Antoine Pitrou
Antoine Pitrou added the comment: Ok, I've committed the patch to 3.3 since it can be useful with the new wait() method. Thanks! -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker

[issue14300] dup_socket() on Windows should use WSA_FLAG_OVERLAPPED

2012-03-31 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5be4d8fc9c44 by Antoine Pitrou in branch 'default': Issue #14300: Under Windows, sockets created using socket.dup() now allow overlapped I/O. http://hg.python.org/cpython/rev/5be4d8fc9c44 -- nosy: +python-dev _

[issue14300] dup_socket() on Windows should use WSA_FLAG_OVERLAPPED

2012-03-14 Thread sbt
sbt added the comment: pitrou wrote: > Are you sure this is desired? Nowhere can I think of a place in the > stdlib where we use overlapped I/O on sockets. multiprocessing.connection.wait() does overlapped zero length reads on sockets. It's documentation currently claims that it works with so

[issue14300] dup_socket() on Windows should use WSA_FLAG_OVERLAPPED

2012-03-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: Are you sure this is desired? Nowhere can I think of a place in the stdlib where we use overlapped I/O on sockets. -- nosy: +pitrou ___ Python tracker ___

[issue14300] dup_socket() on Windows should use WSA_FLAG_OVERLAPPED

2012-03-14 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc added the comment: Which problem are you trying to solve? Can this change be tested somehow? -- nosy: +amaury.forgeotdarc ___ Python tracker ___ ___

[issue14300] dup_socket() on Windows should use WSA_FLAG_OVERLAPPED

2012-03-14 Thread sbt
New submission from sbt : According to Microsoft's documentation sockets created using socket() have the overlapped attribute, but sockets created with WSASocket() do not unless you pass the WSA_FLAG_OVERLAPPED flag. The documentation for WSADuplicateSocket() says If the source process uses