[issue14313] zipfile should raise an exception for unsupported compression methods

2012-11-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8feaa8d04c56 by Ezio Melotti in branch '2.7': #14313: zipfile now raises NotImplementedError when the compression type is unknown. http://hg.python.org/cpython/rev/8feaa8d04c56 New changeset b193a5dc7a58 by Ezio Melotti in branch '3.2': #14313:

[issue14313] zipfile should raise an exception for unsupported compression methods

2012-11-18 Thread Ezio Melotti
Ezio Melotti added the comment: Fixed, thanks for the patches! -- assignee: - ezio.melotti nosy: +ezio.melotti resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org

[issue14313] zipfile should raise an exception for unsupported compression methods

2012-11-01 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file25407/zipfile_unsupported_compression.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14313 ___

[issue14313] zipfile should raise an exception for unsupported compression methods

2012-11-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Éric, this changes already in 3.3 (changeset 596b0eaeece8 + part of changeset fccdcd83708a). This two patches only backport the fix to 2.7 and 3.2. -- versions: -Python 3.3, Python 3.4 ___ Python tracker

[issue14313] zipfile should raise an exception for unsupported compression methods

2012-10-10 Thread Éric Araujo
Éric Araujo added the comment: Raising priority won’t give more free time to the module maintainer, or change the planned date for the next release. Thanks for reviewing the patch however, it is helpful. Did you apply it and run the test suite? -- versions: +Python 3.3, Python 3.4

[issue14313] zipfile should raise an exception for unsupported compression methods

2012-10-10 Thread Stephen McInerney
Stephen McInerney added the comment: I visually reviewed the patch, it's fine by me. (Am not set up to compile it.) When is 2.7.3.x release planned? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14313

[issue14313] zipfile should raise an exception for unsupported compression methods

2012-10-09 Thread Stephen McInerney
Stephen McInerney added the comment: The patch is great, can you approve it urgently please? It is seriously buggy to silently return a bad filestream, and not just throw the exception. I just wasted over a day's productivity due to this. I'm not alone. I would argue for raising priority to

[issue14313] zipfile should raise an exception for unsupported compression methods

2012-05-16 Thread Serhiy Storchaka
Serhiy Storchaka storch...@gmail.com added the comment: I still like NotImplementedError more than RuntimeError, though. Well. here are patches for Python 3.2 and 2.7 (backported changeset 596b0eaeece8 + part of changeset fccdcd83708a). -- Added file:

[issue14313] zipfile should raise an exception for unsupported compression methods

2012-05-14 Thread Éric Araujo
Changes by Éric Araujo mer...@netwok.org: -- keywords: +needs review stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14313 ___

[issue14313] zipfile should raise an exception for unsupported compression methods

2012-05-14 Thread Serhiy Storchaka
Serhiy Storchaka storch...@gmail.com added the comment: Modified patch adopted in 3.3 (changeset 596b0eaeece8), therefore the current patch only applies to 3.2 and 2.7. If this is a new feature, the issue can be closed. -- nosy: +loewis, storchaka versions: -Python 3.3

[issue14313] zipfile should raise an exception for unsupported compression methods

2012-05-14 Thread Martin v . Löwis
Martin v. Löwis mar...@v.loewis.de added the comment: Returning the compressed data from read() is clearly a bug (IMO), so detecting that and reporting an exception would be a bug fix. I still like NotImplementedError more than RuntimeError, though. --

[issue14313] zipfile should raise an exception for unsupported compression methods

2012-04-29 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- keywords: +patch Added file: http://bugs.python.org/file25407/zipfile_unsupported_compression.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14313

[issue14313] zipfile should raise an exception for unsupported compression methods

2012-03-16 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: The requested change is arguably a new feature, but it seems to me that the current behavior is not acceptable and should be changed. -- title: zipfile does not unpack files from archive (files extracted have zero length) - zipfile