[issue14332] Better explain "junk" concept in difflib doc

2014-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0a69b1e8b7fe by Andrew Kuchling in branch 'default': #14332: provide a better explanation of junk in difflib docs http://hg.python.org/cpython/rev/0a69b1e8b7fe -- nosy: +python-dev ___ Python tracker

[issue14332] Better explain "junk" concept in difflib doc

2014-03-19 Thread A.M. Kuchling
Changes by A.M. Kuchling : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ __

[issue14332] Better explain "junk" concept in difflib doc

2014-03-19 Thread Eli Bendersky
Eli Bendersky added the comment: Revised patch LGTM. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue14332] Better explain "junk" concept in difflib doc

2014-03-18 Thread Éric Araujo
Éric Araujo added the comment: amk, if you’re satisfied with your patch, I think you can go ahead and commit it. -- versions: +Python 3.4 -Python 3.2 ___ Python tracker ___

[issue14332] Better explain "junk" concept in difflib doc

2014-03-18 Thread A.M. Kuchling
A.M. Kuchling added the comment: Thanks for your patch! I took it and added some more text describing what junk is, and clarifying that junk affects what's matched but doesn't cause any differences to be ignored. -- nosy: +akuchling stage: needs patch -> patch review Added file: http:

[issue14332] Better explain "junk" concept in difflib doc

2014-03-17 Thread Alba Magallanes
Alba Magallanes added the comment: I removed the References to 2.x version. -- Added file: http://bugs.python.org/file34479/issue14332_2.patch ___ Python tracker ___

[issue14332] Better explain "junk" concept in difflib doc

2014-03-16 Thread Alba Magallanes
Alba Magallanes added the comment: I would like to help with this issue. I'm attaching a patch for it. -- keywords: +patch nosy: +albamagallanes Added file: http://bugs.python.org/file34451/issue14332.patch ___ Python tracker

[issue14332] Better explain "junk" concept in difflib doc

2013-10-08 Thread Eli Bendersky
Eli Bendersky added the comment: Tim, any suggestions? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue14332] Better explain "junk" concept in difflib doc

2012-07-16 Thread Eli Bendersky
Eli Bendersky added the comment: I agree. Any improvement is preferred over just letting this decay in the issue tracker ;-) -- ___ Python tracker ___ _

[issue14332] Better explain "junk" concept in difflib doc

2012-07-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: I guess I should try to come up with something that is an improvement, even if not perfect. -- ___ Python tracker ___

[issue14332] Better explain "junk" concept in difflib doc

2012-07-14 Thread Eli Bendersky
Eli Bendersky added the comment: ping -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue14332] Better explain "junk" concept in difflib doc

2012-03-16 Thread Weronika Patena
Weronika Patena added the comment: Ah, I see. True, the ndiff docstring doesn't actually explain what junk IS - I was just engaging in wishful thinking and assuming it did the thing I wanted. A better explanation would help. -- ___ Python tracker

[issue14332] Better explain "junk" concept in difflib doc

2012-03-16 Thread Terry J. Reedy
Terry J. Reedy added the comment: I reproduced the observed behavior in 3.3.0a. However, I am rather sure it is not a bug. In any case, linejunk is not ignored. Passing 'lambda x: 1/0' causes ZeroDivisionError, proving that it gets called. The body of ndiff(linejunk,charjunk,a,b) is return