Roundup Robot added the comment:
New changeset 64e004737837 by R David Murray in branch '3.3':
#18324: set_payload now correctly handles binary input.
http://hg.python.org/cpython/rev/64e004737837
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 7c807bc15fa8 by R David Murray in branch '3.3':
#14360: Add news item.
http://hg.python.org/cpython/rev/7c807bc15fa8
New changeset 36cc8b0446b3 by R David Murray in branch 'default':
Merge #14360: Add news item.
Roundup Robot added the comment:
New changeset 1d5856849e64 by R David Murray in branch '3.3':
#14360: make encoders.encode_quopri work.
http://hg.python.org/cpython/rev/1d5856849e64
New changeset 9046ef201591 by R David Murray in branch 'default':
Merge #14360: make encoders.encode_quopri
Changes by R. David Murray rdmur...@bitdance.com:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14360
___
___
R. David Murray added the comment:
This should now be fixed. Calling MIMEApplication with a binary payload and
passing it encode_quopri as the encoder will now actually work.
--
resolution: - fixed
stage: needs patch - committed/rejected
versions: +Python 3.4 -Python 3.2
Changes by R. David Murray rdmur...@bitdance.com:
--
components: +email -Library (Lib)
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14360
___
___
Dmitry Shachnev mity...@gmail.com added the comment:
Then, which types of argument should encode_* functions take (I think str
should be supported, and it's not a case here as encode_quopri will only
accept bytes)?
I meant which types of *payload* should they accept. Here's an illustration
R. David Murray rdmur...@bitdance.com added the comment:
email in python3 doesn't necessarily work with binary payloads. (Obviously
here you've found the opposite problem, but it is in methods that aren't used
by the package itself.) There aren't any tests of binary payloads in the test
Dmitry Shachnev mity...@gmail.com added the comment:
(Sorry for not replying earlier).
I think the main priority here is getting things working, not the tests (so I
have little interest in that).
First of all, should quopri.encodestring() really return bytes? Everything it
returns is ascii
R. David Murray rdmur...@bitdance.com added the comment:
Well, a patch won't get committed if it lacks tests, so commit would have to
wait until I have time to write some, then.
The encode_ methods (from email.encoders) take *message* objects as their
arguments. MIMEText internally converts
Dmitry Shachnev mity...@gmail.com added the comment:
In fact, there's really no reason to call an encode_ method at all, since if
you pass a string to MIMEText when giving it a non-ascii unicode string, it
will default to utf-8 and do the appropriate CTE encoding.
No, it doesn't:
Python
R. David Murray rdmur...@bitdance.com added the comment:
Oh, you are right. I even noted that bug in my PyCon talk, but immediately
forgot about it :( I do intend to fix it.
You can get it to work by explicitly passing the charset:
x = MIMEText('йцукен', _charset='utf8')
str(x)
Dmitry Shachnev mity...@gmail.com added the comment:
You can get it to work by explicitly passing the charset
Thanks, I didn't know about that.
Given the above, do you need it anymore?
No.
--
___
Python tracker rep...@bugs.python.org
New submission from Dmitry Shachnev mity...@gmail.com:
Currently my /usr/lib/python3.2/email/encoders.py has this code:
def _qencode(s):
enc = _encodestring(s, quotetabs=True)
# Must encode spaces, which quopri.encodestring() doesn't do
return enc.replace(' ', '=20')
The problem is
Changes by Dmitry Shachnev mity...@gmail.com:
--
type: crash - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14360
___
___
R. David Murray rdmur...@bitdance.com added the comment:
Interesting. Apparently we have no tests for the encode_ functions, nor do we
use them inside the email package itself (except for encode_7or8bit).
Do you have any interest in writing a patch with tests?
--
assignee: -
16 matches
Mail list logo
