[issue14492] pdeps.py has_key

2012-04-05 Thread R. David Murray
R. David Murray added the comment: Thanks, Popa. I made some style changes to the tests, but otherwise used your patch. One small note: your might want to see about setting your editor to show whitespace at the ends of lines, or use the 'make patchcheck' command to check for whitespace. Ou

[issue14492] pdeps.py has_key

2012-04-05 Thread Roundup Robot
Roundup Robot added the comment: New changeset e9b8115c5b25 by R David Murray in branch '3.2': #14492: fix some bugs in Tools/scripts/pdeps.py. http://hg.python.org/cpython/rev/e9b8115c5b25 New changeset 26a7cc129b3d by R David Murray in branch 'default': Merge #14492: fix some bugs in Tools/sc

[issue14492] pdeps.py has_key

2012-04-05 Thread Popa Claudiu
Popa Claudiu added the comment: Hello. Here is the new patch. There was a few more problems: 1. in process, fp wasn't closed 2. in process, m_import.match(line) >= 0 could fail if the regular expression didn't matched on that line I've included the tests, too. -- Added file: http://bu

[issue14492] pdeps.py has_key

2012-04-04 Thread Georg Brandl
Georg Brandl added the comment: Should be "x not in y" BTW to be idiomatic, not "not x in y". -- nosy: +georg.brandl ___ Python tracker ___ _

[issue14492] pdeps.py has_key

2012-04-04 Thread R. David Murray
R. David Murray added the comment: This one is not a syntax error, so the new 'sundry' tests don't catch it. Want to write a test for this one? -- nosy: +r.david.murray ___ Python tracker ___

[issue14492] pdeps.py has_key

2012-04-04 Thread R. David Murray
Changes by R. David Murray : -- stage: -> test needed type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue14492] pdeps.py has_key

2012-04-04 Thread Popa Claudiu
New submission from Popa Claudiu : Tools/pdeps.py is using has_key for a dictionary. The attached patch fixes this issue. -- files: pdeps.patch keywords: patch messages: 157471 nosy: Popa.Claudiu priority: normal severity: normal status: open title: pdeps.py has_key Added file: http://b

[issue14492] pdeps.py has_key

2012-04-04 Thread Popa Claudiu
Changes by Popa Claudiu : -- components: +Demos and Tools versions: +Python 3.2, Python 3.3 ___ Python tracker ___ ___ Python-bugs-lis