[issue14578] importlib doesn't check Windows registry for paths

Martin v. Löwis added the comment: Amaury's patch nearly worked; committed with slight modifications. -- dependencies: -Cannot build importlib.h on Windows resolution: -> fixed status: open -> closed ___ Python tracker

[issue14578] importlib doesn't check Windows registry for paths

Roundup Robot added the comment: New changeset bd58c421057c by Martin v. Löwis in branch 'default': Issue #14578: Support modules registered in the Windows registry again. http://hg.python.org/cpython/rev/bd58c421057c -- nosy: +python-dev ___ Python t

[issue14578] importlib doesn't check Windows registry for paths

Georg Brandl added the comment: OK, demoting. -- priority: release blocker -> deferred blocker ___ Python tracker ___ ___ Python-bugs

[issue14578] importlib doesn't check Windows registry for paths

Brian Curtin added the comment: > I would really like to release beta2 this weekend. Is it possible to get > this resolved by then? As others stated, I'm not sure it's entirely necessary. Given the two dependencies that need to be fixed before this one can move forward, I don't think it's h

[issue14578] importlib doesn't check Windows registry for paths

Amaury Forgeot d'Arc added the comment: pywin32 used to install modules this way, but it seems it doesn't anymore: http://pywin32.hg.sourceforge.net/hgweb/pywin32/pywin32/file/16707e6f1624/pywin32_postinstall.py#l307 # It is possible people with old versions installed with still have #

[issue14578] importlib doesn't check Windows registry for paths

Antoine Pitrou added the comment: > I would really like to release beta2 this weekend. Is it possible to get > this resolved by then? At worse, perhaps 3.3 can be released without this feature. I don't know who relies on it. -- nosy: +pitrou ___

[issue14578] importlib doesn't check Windows registry for paths

Changes by Antoine Pitrou : -- nosy: +loewis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue14578] importlib doesn't check Windows registry for paths

Amaury Forgeot d'Arc added the comment: So I tried to make proper changes in _bootstrap.py, and regenerate importlib.h on Linux. I don't have any Windows machine; all this is completely untested, but at least it can help some Windows developer to finish the work, and write unit tests... (in ca

[issue14578] importlib doesn't check Windows registry for paths

Georg Brandl added the comment: I would really like to release beta2 this weekend. Is it possible to get this resolved by then? -- ___ Python tracker ___ _

[issue14578] importlib doesn't check Windows registry for paths

Eric Snow added the comment: Brian, perhaps the problem described in issue15431 ("Cannot build importlib.h on Windows") is part of the problem for you here. -- ___ Python tracker _

[issue14578] importlib doesn't check Windows registry for paths

Brett Cannon added the comment: I just wanted to say that Amaury's proof-of-concept looks right (although what is returned by the registry isn't a "fullname" but a file path so I would at least change that variable name and you wouldn't append this mat path finder but instead insert it before

[issue14578] importlib doesn't check Windows registry for paths

Amaury Forgeot d'Arc added the comment: importlib.h is not rebuilt on Windows, see issue15431. -- dependencies: +Cannot build importlib.h on Windows ___ Python tracker ___ _

[issue14578] importlib doesn't check Windows registry for paths

Brian Curtin added the comment: I'm not sure what the deal is but I can't get the changes to apply (fitting Amaury's patch into _boostrap.py), meaning nothing I change to the _boostrap.py file changes how anything operates. I don't have much time to learn all of this stuff and make it work on

[issue14578] importlib doesn't check Windows registry for paths

Amaury Forgeot d'Arc added the comment: I don't have Windows, but here is an example of a WindowsRegistryImporter, written outside importlib (the script also contains a fake implementation of winreg, so I could test it...) Of course it needs to be rewritten to fit in _bootstrap.py; at least

[issue14578] importlib doesn't check Windows registry for paths

Brett Cannon added the comment: So it should end up in Lib/importlib/_bootstrap.py since it is directly part of how import works. The original code as found in Python 3.2 for PyWin_FindRegisteredModule() is referenced in Python/import.c and is implemented in PC/import_nt.c. You will want to c

[issue14578] importlib doesn't check Windows registry for paths

Brian Curtin added the comment: Can someone tell me where you want this changed? I guess Lib/imp.py in the find_module function, based on previous mention of imp.find_module? That's shown as deprecated so I'm hesitant to start there. I don't really know anything about importlib, especially no

[issue14578] importlib doesn't check Windows registry for paths

Brian Curtin added the comment: Sorry, I've been too busy to get caught up with this. I'm away most of today but I can try to take a look tonight. -- ___ Python tracker ___ ___

[issue14578] importlib doesn't check Windows registry for paths

Georg Brandl added the comment: Ping. Brian? I'd rather have some testing period for this, so I'm reluctant to release b2 without it. -- ___ Python tracker ___ ___

[issue14578] importlib doesn't check Windows registry for paths

Georg Brandl added the comment: Moving back to blocker for beta2. -- priority: deferred blocker -> release blocker ___ Python tracker ___ ___

[issue14578] importlib doesn't check Windows registry for paths

Brian Curtin added the comment: I will take a look at it shortly...was too busy with installer/path issues and then PEP 397 last week. -- ___ Python tracker ___ ___

[issue14578] importlib doesn't check Windows registry for paths

Brett Cannon added the comment: Yes, it should be tackled soon, but I lack Windows access so I can't do the work myself. Basically no one seems to use or care about this feature so it might die "on the vine" if someone doesn't step forward. -- ___

[issue14578] importlib doesn't check Windows registry for paths

Georg Brandl added the comment: OTOH, I don't want it to block beta1. -- priority: release blocker -> deferred blocker ___ Python tracker ___ ___

[issue14578] importlib doesn't check Windows registry for paths

Georg Brandl added the comment: Brett (and/or Brian?), this sounds like it should be tackled soon, to give Windows users enough time of testing 3.3. -- nosy: +georg.brandl ___ Python tracker _

[issue14578] importlib doesn't check Windows registry for paths

Brett Cannon added the comment: FYI, I just deleted PC/import_nt.c as it stopped compiling after my removal of _imp.get_suffixes(). Obviously hg has the history of the file so if someone needs to resurrect it there shouldn't be much issue. -- ___ P

[issue14578] importlib doesn't check Windows registry for paths

Brett Cannon added the comment: You could just expose it, but on Windows I believe all extension modules are builtins, so you should be able to properly use _winreg to get at the registry and thus not require keeping the C code around. But that's just a guess. -- ___

[issue14578] importlib doesn't check Windows registry for paths

Changes by Brian Curtin : -- nosy: +brian.curtin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue14578] importlib doesn't check Windows registry for paths

Eric Snow added the comment: Yeah, that's one part of imp.find_module that I kind of set aside too (the #ifdef MS_COREDLL sections in Python/import.c). For now would it be sufficient to expose _PyWin_FindRegisteredModule() privately with a wrapper in the imp module? --

[issue14578] importlib doesn't check Windows registry for paths

Changes by Eric Snow : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue14578] importlib doesn't check Windows registry for paths

New submission from Brett Cannon : Because I don't have access to Windows, importlib doesn't check the Windows registry for paths to search (see the use of _PyWin_FindRegisteredModule() in Python/import.c and its definition in PC/import_nt.c). I am considering this a release blocker as once im