[issue14591] Value returned by random.random() out of valid range on 64-bit

Roundup Robot added the comment: New changeset 6df0b4ed8617 by Mark Dickinson in branch '2.7': Closes #14591: Random.jumpahead could produce an invalid MT state on 64-bit machines. http://hg.python.org/cpython/rev/6df0b4ed8617 -- nosy: +python-dev resolution: -> fixed stage: commit re

[issue14591] Value returned by random.random() out of valid range on 64-bit

Changes by Raymond Hettinger : -- assignee: rhettinger -> mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue14591] Value returned by random.random() out of valid range on 64-bit

Raymond Hettinger added the comment: The patch is fine but would be a bit better if the two loop passes were merged and if the "tmp" variable were renamed to something like "nonzero" or somesuch. -- ___ Python tracker

[issue14591] Value returned by random.random() out of valid range on 64-bit

Mark Dickinson added the comment: Raymond, can this patch be applied? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue14591] Value returned by random.random() out of valid range on 64-bit

Serhiy Storchaka added the comment: > The = 0x8000UL was intentional. The low-order 31 bits of mt[0] don't > form part of the state of the Mersenne Twister: the resulting random stream > isn't affected by their values. Thanks, I have no more questions. -- _

[issue14591] Value returned by random.random() out of valid range on 64-bit

Mark Dickinson added the comment: Responding to a comment from Serhiy on Rietveld: > Modules/_randommodule.c:442: mt[0] = 0x8000UL; > mt[0] |= 0x8000UL (according to the comment)? The = 0x8000UL was intentional. The low-order 31 bits of mt[0] don't form part of the state of the M

[issue14591] Value returned by random.random() out of valid range on 64-bit

Mark Dickinson added the comment: Done. -- Added file: http://bugs.python.org/file25508/random_jumpahead_5.patch ___ Python tracker ___ _

[issue14591] Value returned by random.random() out of valid range on 64-bit

Antoine Pitrou added the comment: In test_random, you should use assertLess so that the offending value is displayed on failure. -- ___ Python tracker ___ _

[issue14591] Value returned by random.random() out of valid range on 64-bit

Changes by Mark Dickinson : -- stage: -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue14591] Value returned by random.random() out of valid range on 64-bit

Mark Dickinson added the comment: Dang. Patch now attached. -- Added file: http://bugs.python.org/file25304/random_jumpahead_4.patch ___ Python tracker ___

[issue14591] Value returned by random.random() out of valid range on 64-bit

Mark Dickinson added the comment: Patch with unit test. :-) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue14591] Value returned by random.random() out of valid range on 64-bit

Antoine Pitrou added the comment: The patch should probably come with an unit test. -- nosy: +pitrou ___ Python tracker ___ ___ Pytho

[issue14591] Value returned by random.random() out of valid range on 64-bit

Changes by STINNER Victor : -- title: Value returned by random.random() out of valid range -> Value returned by random.random() out of valid range on 64-bit ___ Python tracker _