[issue14684] zlib set dictionary support inflateSetDictionary

Roundup Robot added the comment: New changeset 1cfa44cb5af0 by Nadeem Vawda in branch 'default': Document the rest of zlib.compressobj()'s arguments. http://hg.python.org/cpython/rev/1cfa44cb5af0 -- ___ Python tracker

[issue14684] zlib set dictionary support inflateSetDictionary

Nadeem Vawda added the comment: > Just saw this on the checkins list; where are the other options documented? They aren't, AFAIK. I've been planning on adding them when I've got time (based on the zlib manual at http://zlib.net/manual.html), but with the upcoming feature freeze for 3.3, this i

[issue14684] zlib set dictionary support inflateSetDictionary

Jim Jewett added the comment: Just saw this on the checkins list; where are the other options documented? """ PyDoc_STRVAR(compressobj__doc__, -"compressobj([level]) -- Return a compressor object.\n" +"compressobj([level[, method[, wbits[, memlevel[, strategy[, zdict]])\n" +" -- Return a

[issue14684] zlib set dictionary support inflateSetDictionary

Nadeem Vawda added the comment: Committed. Once again, thanks for the patch! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue14684] zlib set dictionary support inflateSetDictionary

Roundup Robot added the comment: New changeset dd4f7d5c51c7 by Nadeem Vawda in branch 'default': Issue #14684: Add support for predefined compression dictionaries to the zlib module. http://hg.python.org/cpython/rev/dd4f7d5c51c7 -- nosy: +python-dev ___

[issue14684] zlib set dictionary support inflateSetDictionary

Nadeem Vawda added the comment: I plan to commit it (along with the buffer API changes) tomorrow. -- ___ Python tracker ___ ___ Pytho

[issue14684] zlib set dictionary support inflateSetDictionary

Jesús Cea Avión added the comment: So my question is easy: could we apply this patch as is and defer any "improvement" to 3.4?. The risk of not doing so would be to miss 3.3 completely. -- ___ Python tracker

[issue14684] zlib set dictionary support inflateSetDictionary

Nadeem Vawda added the comment: > To restate my position: the need is for an immutable string of bytes, [...] I disagree that we should require the dictionary to be immutable - if the caller wishes to use a mutable buffer here, it is their responsibility to ensure that it is not modified until

[issue14684] zlib set dictionary support inflateSetDictionary

Sam Rushing added the comment: I think other than the disagreement about whether the dictionary constructor arg should be a buffer object, it's good to go. To restate my position: the need is for an immutable string of bytes, and that's exactly what PyBytes_Type is for. I see no advantage to

[issue14684] zlib set dictionary support inflateSetDictionary

Jesús Cea Avión added the comment: Sam, the window for Python 3.3 integration is almost close. Could you possibly update your patch with Nadeem's feedback?. -- ___ Python tracker _

[issue14684] zlib set dictionary support inflateSetDictionary

Nadeem Vawda added the comment: The code should be changed to use the buffer API (instead of accepting only bytes objects). Other than that, I think it's ready for integration. -- ___ Python tracker __

[issue14684] zlib set dictionary support inflateSetDictionary

Changes by Éric Araujo : -- keywords: +needs review stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue14684] zlib set dictionary support inflateSetDictionary

Jesús Cea Avión added the comment: Status of this feature?. Ready to integrate? -- ___ Python tracker ___ ___ Python-bugs-list mailin

[issue14684] zlib set dictionary support inflateSetDictionary

Sam Rushing added the comment: renames dict->zdict, splits the test, adds BEGIN/END around inflate call. -- Added file: http://bugs.python.org/file25472/zlib_set_dictionary_4.patch ___ Python tracker _

[issue14684] zlib set dictionary support inflateSetDictionary

Nadeem Vawda added the comment: I've posted a review on Rietveld. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue14684] zlib set dictionary support inflateSetDictionary

Changes by Nadeem Vawda : -- nosy: +nadeem.vawda ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue14684] zlib set dictionary support inflateSetDictionary

Éric Araujo added the comment: Added a few comments on Rietveld. -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list ma

[issue14684] zlib set dictionary support inflateSetDictionary

Changes by Sam Rushing : Added file: http://bugs.python.org/file25449/zlib_set_dictionary_3.patch ___ Python tracker ___ ___ Python-bugs-list

[issue14684] zlib set dictionary support inflateSetDictionary

Sam Rushing added the comment: Updated version of the patch: extends the test, including a test of the streaming behavior needed for SPDY (both compression and decompression). Also wik: copy()/uncopy() are aware of the 'dict' attribute. -- ___ Pyth

[issue14684] zlib set dictionary support inflateSetDictionary

Sam Rushing added the comment: Argh, probably need to add the 'dict' field to the copy() method. -- ___ Python tracker ___ ___ Python

[issue14684] zlib set dictionary support inflateSetDictionary

Sam Rushing added the comment: This test is rather large, since it includes the predefined SPDY draft 2 dictionary, and some real-world data. Not sure what the policy is on including so much data in a test. If there's enough time I could make a smaller test that also verifies the correct be

[issue14684] zlib set dictionary support inflateSetDictionary

Sam Rushing added the comment: Ok, here's the patch. It has a single short test. For use with SPDY, it's necessary to test that the following stream data also correctly decompresses, I'll attach that to the next comment. -- Added file: http://bugs.python.org/file25446/zlib_set_dicti

[issue14684] zlib set dictionary support inflateSetDictionary

Changes by Jesús Cea Avión : -- assignee: serwy -> nosy: -serwy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue14684] zlib set dictionary support inflateSetDictionary

Jesús Cea Avión added the comment: Retargetting to python 3.3. If you hurry a bit and I find your patch acceptable (remember the tests!), I will try to integrate it. -- assignee: -> serwy nosy: +serwy versions: +Python 3.3 -Python 3.4 ___ Python t

[issue14684] zlib set dictionary support inflateSetDictionary

Sam Rushing added the comment: I'm currently reworking this so that the dictionaries are provided in the constructor, and inflateSetDictionary() is called automatically. I've gone over the zlib RFC's and zlibmodule.c, and I'm fairly certain that whatever usage mode might involve multiple cal

[issue14684] zlib set dictionary support inflateSetDictionary

Jesús Cea Avión added the comment: A dictionary could be provided an init time. Then, the Z_NEED_DICT could be intercepted in the binding and automatically inject the dictionary provided in the init. Anyway, for a patch to be approved, we need a test too. PS: Why is this NOT targeted to 3.3?

[issue14684] zlib set dictionary support inflateSetDictionary

New submission from Sam Rushing : Google's SPDY protocol requires the use of a pre-defined compression dictionary. The current zlib module doesn't expose the two functions for setting the dictionary. This patch is minimal in the sense that it only exposes the two functions, but unfortunately