Martin Panter added the comment:
FWIW urlopen() already handles space characters in the Location target of
redirects; see HTTPRedirectHandler.redirect_request(). So I think it is
reasonable to handle space characters in user-supplied URLs also, if it is done
properly.
--
nosy:
Ross Lagerwall rosslagerw...@gmail.com added the comment:
It looks like this broke the build bots:
http://buildbot.python.org/all/builders/AMD64%20Ubuntu%20LTS%202.7/builds/66/steps/test/logs/stdio
--
assignee: - orsenthil
nosy: +rosslagerwall
status: closed - open
Stephen Thorne step...@thorne.id.au added the comment:
Here's a followup patch that fixes the trunk build for me.
This will unbreak the builds as well as fixing this bug, but it should be
investigated why URLopener calls to_bytes() and Request does not. Ideally this
interface should be
Éric Araujo mer...@netwok.org added the comment:
I’m not sure urllib should accept invalid (non-escaped) URLs; a higher-level
application can do so, but for the low-level stdlib module it is more debatable.
--
nosy: +eric.araujo
___
Python tracker
Senthil Kumaran sent...@uthcode.com added the comment:
It seems to me that toBytes in urllib was introduce to restrict the
allowance of urls which were sent as unicode strings. We wanted urls
to be ascii strings in Python2.
Senthil Kumaran sent...@uthcode.com added the comment:
Yeah, I am thinking so as well in that case, the test_cookielib.py
test case may need a change.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14826
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset ee1828dc3bf6 by Senthil Kumaran in branch '3.2':
issue 14826 - Address the buildbot failure ( explanation msg164973)
http://hg.python.org/cpython/rev/ee1828dc3bf6
New changeset dc30111a5d7e by Senthil Kumaran in
Senthil Kumaran sent...@uthcode.com added the comment:
The last change should settle the buildbots, But I would like to come
back to this issue again tomorrow with focus - 3.3to see if we can
deal with removing to_bytes and then in 2.7 to see if something can
done to test_cookielib.py test
Antoine Pitrou pit...@free.fr added the comment:
Senthil, do you read python-dev? I think this change was prematurate from the
start (nevermind the fact that you didn't run the test suite before committing).
For example, if you have an URL with a non-ASCII domain name such as
Christian Heimes li...@cheimes.de added the comment:
The docs [1] state that `url should be a string containing a valid URL.` An URL
with a space ' ' is not a valid URL as the space must be quoted as %20. The
brackets may also cause problems as they are not valid xs:anyURI chars.
I vote for
Senthil Kumaran sent...@uthcode.com added the comment:
On Sun, Jul 8, 2012 at 2:30 AM, Antoine Pitrou rep...@bugs.python.org wrote:
Senthil, do you read python-dev? I think this change was prematurate from the
start (nevermind the fact that you didn't run the test suite before
committing).
Senthil Kumaran sent...@uthcode.com added the comment:
On Sun, Jul 8, 2012 at 9:42 AM, Christian Heimes rep...@bugs.python.org wrote:
I vote for reverting the chances as they break the API. You could improve the
docs and emphasize that URLs must be quoted correctly as the module doesn't
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset ebd37273e0fe by Senthil Kumaran in branch '3.2':
revert the changes done for issue14826 - quoting witin Request is not desirable.
http://hg.python.org/cpython/rev/ebd37273e0fe
--
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset a4bdb637d818 by Senthil Kumaran in branch 'default':
revert the changes done for issue14826 - quoting witin Request is not desirable.
http://hg.python.org/cpython/rev/a4bdb637d818
--
Stephen Thorne step...@thorne.id.au added the comment:
Here is a patch that uses the same quoting logic in
urllib.request.Request.__init__ as is used by urllib.request.URLopener.open()
--
keywords: +patch
nosy: +jerub
versions: +Python 3.3 -Python 2.7
Added file:
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 01c8d800efd2 by Senthil Kumaran in branch '3.2':
Fix issue14826 - make urllib.request.Request quoted url consistent with
URLOpener open method.
http://hg.python.org/cpython/rev/01c8d800efd2
New changeset
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset d931a3b64fd6 by Senthil Kumaran in branch '2.7':
Fix issue14826 - make urllib.request.Request quoted url consistent with
URLOpener open method.
http://hg.python.org/cpython/rev/d931a3b64fd6
--
Changes by Senthil Kumaran sent...@uthcode.com:
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
versions: +Python 2.7, Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14826
Senthil Kumaran sent...@uthcode.com added the comment:
Thanks for the patch, Stephen.
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14826
___
New submission from Wichert Akkerman wich...@wiggy.net:
There appears to be an odd networking issue with how urllib2 sends HTTP
requests. Downloading an image from maw.liquifire.com gives an error:
$ python -c 'import urllib2 ;
Anthony Long antl...@gmail.com added the comment:
http://maw.liquifire.com/maw?set=image[2302.000.13314%20a]call=url[file:325x445]
works properly. Notice the %20 instead of ' '
--
nosy: +antlong
___
Python tracker rep...@bugs.python.org
21 matches
Mail list logo
