[issue14884] Windows Build instruction typo

2012-05-22 Thread Michael Driscoll
New submission from Michael Driscoll : In http://docs.python.org/devguide/setup.html#windows the devguide mentions that the user must go to the "Build" menu to run "Build Solution". When I tried doing that with Visual C++ 2010 per the instructions, I discovered that there is no "Build" menu an

[issue14884] Windows Build instruction typo

2012-05-22 Thread Brian Curtin
Brian Curtin added the comment: Would you mind taking a screenshot of where "Build Solution" appears? You'll probably need to hold CTRL+print screen to make sure the menu doesn't retract. As seen in http://i.imgur.com/XvXa5.png I have the menu as described in the guide and it's the one I've s

[issue14884] Windows Build instruction typo

2012-05-22 Thread Michael Driscoll
Michael Driscoll added the comment: @Brian - Sorry I didn't include a screenshot earlier. I was running it on a machine without good screen capturing software. I've rectified that and attached a screenshot for you. I suspect that there's a difference between the VC++ 2010 Express Edition and

[issue14884] Windows Build instruction typo

2012-05-22 Thread Brian Curtin
Brian Curtin added the comment: Weird that they would do that. Given that there is a difference, we should probably list both. Something like "choose the Build Solution option from either the Build or Debug menu depending on your Visual Studio version." Your patch seems to solve something dif

[issue14884] Windows Build instruction typo

2012-05-22 Thread Michael Driscoll
Michael Driscoll added the comment: Yeah, my patch didn't turn out the way I expected. I replaced "Build" with "Debug" and then noticed that it also referred to some kind of "build" drop-down that didn't seem like the right term. I couldn't figure out what the right term was though. Would you

[issue14884] Windows Build instruction typo

2012-05-22 Thread Brian Curtin
Brian Curtin added the comment: May as well fix them both. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue14884] Windows Build instruction typo

2012-05-23 Thread Eli Bendersky
Changes by Eli Bendersky : -- nosy: +eli.bendersky ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue14884] Windows Build instruction typo

2012-05-23 Thread Michael Driscoll
Michael Driscoll added the comment: Here's a new patch that I think addresses both issues. Thanks for your insights. -- Added file: http://bugs.python.org/file25678/setup.patch ___ Python tracker _

[issue14884] Windows Build instruction typo

2012-05-23 Thread Eli Bendersky
Eli Bendersky added the comment: Nitpicking: the drop down (in both VC++ 2008 & 2010 express) is named "Solution Configurations" [note the 's' in the end] But this name does now appear anywhere - only if you hover on the dropbox. I don't mind either way - either leave it what it was, or chang

[issue14884] Windows Build instruction typo

2012-05-23 Thread Michael Driscoll
Michael Driscoll added the comment: @ Eli - Sorry about that. I just went with Brian's wording on that. I didn't realize it was plural. My experience with Visual Studio is limited, although I hope to rectify that at some point. Anyway, I corrected the patch and attached it. Thanks! -

[issue14884] Windows Build instruction typo

2012-05-23 Thread Eli Bendersky
Eli Bendersky added the comment: LGTM. Brian, any objections to commit? P.S. Michael: I usually like numbering successive versions of a patch (like setup.1.patch, setup.2.patch, or a similar scheme) - this makes it easier to refer to more than one version in a discussion without getting confu

[issue14884] Windows Build instruction typo

2012-05-23 Thread Brian Curtin
Brian Curtin added the comment: Looks good to me. Feel free to commit it, Eli. -- assignee: brian.curtin -> ___ Python tracker ___ _

[issue14884] Windows Build instruction typo

2012-05-23 Thread Michael Driscoll
Michael Driscoll added the comment: Thanks for the tip Eli. I'll try to remember to number my patches next time. This is my first time doing this. -- ___ Python tracker ___ ___

[issue14884] Windows Build instruction typo

2012-05-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset e55c65fc3cb4 by Eli Bendersky in branch 'default': Issue #14884: fixed a couple of typos in the Windows build instructions. Patch by Michael Driscoll http://hg.python.org/devguide/rev/e55c65fc3cb4 -- nosy: +python-dev

[issue14884] Windows Build instruction typo

2012-05-23 Thread Eli Bendersky
Eli Bendersky added the comment: Done (with a tiny fix inserting parens to avoid ambiguity in a sentence). Thanks for the contribution! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker