Roundup Robot added the comment:
New changeset 99302634d756 by Berker Peksag in branch 'default':
Issue #14910: Add allow_abbrev parameter to argparse.ArgumentParser.
https://hg.python.org/cpython/rev/99302634d756
--
nosy: +python-dev
___
Python
Berker Peksag added the comment:
Committed. Thank you all for patches and reviews :)
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14910
Berker Peksag added the comment:
The patch LGTM.
In Doc/library/argparse.rst:
- add_help=True)
+ allow_abbrev=True, add_help=True)
should be
add_help=True, allow_abbrev=True)
I'll add a release note and commit it. Thanks!
--
Rémi Rampin added the comment:
It looks like the previous comments were addressed in the latest patch. Is this
still planned for 3.5? Alpha 1 is next week according to PEP478.
--
___
Python tracker rep...@bugs.python.org
Changes by Rémi Rampin remiram...@gmail.com:
--
nosy: +remram
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14910
___
___
Python-bugs-list mailing
Andy Zobro added the comment:
This breaks custom actions.
e.g.:
class dict_action(argparse.Action):
def __init__(self, *a, **k):
argparse.Action.__init__(self, *a, **k)
TypeError: __init__() got an unexpected keyword argument 'allow_abbrev'
--
nosy: +xobes
Andy Zobro added the comment:
Ignore previous comment, I wish I could delete it.
I simply provided the allow_abbrev to the wrong function and spent zero time
investigating the error.
--
___
Python tracker rep...@bugs.python.org
Eli Bendersky added the comment:
Ezio, could you see if your comments were addressed?
Steven, do you want to take another look, or is this OK to commit?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14910
Daniel Eriksson added the comment:
Fixed documentation issues
--
Added file: http://bugs.python.org/file36246/issue14910_6.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14910
___
Daniel Eriksson added the comment:
Updated patch
--
Added file: http://bugs.python.org/file36260/issue14910_7.diff.txt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14910
___
Daniel Eriksson added the comment:
Oh, completely missed comments there too!
I hope I got them all in a good way!
--
Added file: http://bugs.python.org/file36228/issue14910_4.diff
___
Python tracker rep...@bugs.python.org
Daniel Eriksson added the comment:
Sorry for a new patch this close, but just tripple checked the documentation
and noticed a word to much. Made it more clear hopefully
--
Added file: http://bugs.python.org/file36229/issue14910_5.diff
___
Python
Eli Bendersky added the comment:
No worries, Daniel. You should have received an email when comments were posted
to the review, did you? If you you may want to check your settings in the bug
tracker.
I left a couple of additional comments on the documentation file, but other
than that this
Daniel Eriksson added the comment:
Eli, will look into those tomorrow morning, so a final patch will come during
tomorrow. Checked my spam folder - and there they where, fixed the settings now
so I get it faster.
--
___
Python tracker
Changes by Berker Peksag berker.pek...@gmail.com:
--
components: +Library (Lib) -None
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14910
___
Daniel Eriksson added the comment:
Update the patch - issue_14910_3.diff
argparse.rst - merging conflicts
--
nosy: +dan...@starstable.com
Added file: http://bugs.python.org/file36207/issue_14910_3.diff
___
Python tracker rep...@bugs.python.org
Eli Bendersky added the comment:
Daniel, I left some comments in Rietveld. Also it doesn't seem that you
addressed the previously left comments when you fixed up the patch.
--
___
Python tracker rep...@bugs.python.org
paul j3 added the comment:
Update the patch -
test_argparse.py - cleanup spaces
argparse.rst - merging conflicts
--
Added file: http://bugs.python.org/file35190/issue14910_2.patch
___
Python tracker rep...@bugs.python.org
Changes by paul j3 ajipa...@gmail.com:
Removed file: http://bugs.python.org/file35190/issue14910_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14910
___
Changes by paul j3 ajipa...@gmail.com:
Added file: http://bugs.python.org/file35191/issue14910_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14910
___
Changes by Mark Lawrence breamore...@yahoo.co.uk:
--
nosy: -BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14910
___
___
paul j3 added the comment:
For a programmer who needs to turn off this abbreviation matching now, a simple
solution is to subclass ArgumentParser:
class MyParser(ArgumentParser):
def _get_option_tuples(self, option_string):
return []
This could be the place to
Changes by Eric V. Smith e...@trueblade.com:
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14910
___
___
Python-bugs-list
Changes by Eli Bendersky eli...@gmail.com:
--
nosy: +eli.bendersky
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14910
___
___
Python-bugs-list
Mark Lawrence added the comment:
Ping :)
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14910
___
___
Python-bugs-list
Changes by Ugra Dániel daniel.u...@gmail.com:
--
nosy: +daniel.ugra
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14910
___
___
Python-bugs-list
Changes by R. David Murray rdmur...@bitdance.com:
--
nosy: +Michael.Edwards
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14910
___
___
Steven Bethard steven.beth...@gmail.com added the comment:
I think it makes a lot of sense to allow people to disable abbreviations, so +1
on the feature request.
The patch looked good. There was one typo - using accept_abbrev in the
docstring instead of allow_abbrev as in the implementation,
Steven Bethard steven.beth...@gmail.com added the comment:
Sorry, my mistake, the doc changes were already in the patch. I just checked
them and they look good too. So everything's ready to commit.
Thanks for your contribution!
--
___
Python
R. David Murray rdmur...@bitdance.com added the comment:
Jonathan: we are in feature freeze right now preparing 3.3 for release, so you
might want to ping the issue once 3.3 is out to remind us to do the checkin.
--
nosy: +r.david.murray
___
Python
Jonathan Paugh jpa...@gmx.us added the comment:
I am dubious as to the use of this: I think resolving partial args is one of
the best thing since invented since sliced bread.
However, it's a good project to get my feet wet, so I'll take it on. I should
have a patch later today--I'm working on
Jonathan Paugh jpa...@gmx.us added the comment:
I created a patch that exibhts the requested behavior. I added tests, and
updated the documentation. I ran the test-suite against a build of Python
3.3.0a3+, and all tests check out.
This changes the public API of argparse.ArgumentParser and of
Changes by Jens Jährig jaehrig.j...@googlemail.com:
--
components: None
nosy: jens.jaehrig
priority: normal
severity: normal
status: open
title: argparse disable abbreviation
type: enhancement
versions: Python 2.6, Python 2.7
___
Python tracker
New submission from Jens Jährig jaehrig.j...@googlemail.com:
argparse uses per default abbreviation in unambiguous cases.
I don't want abbreviation and i'd like to disable it.
But theres no option to do this.
http://docs.python.org/library/argparse.html#argument-abbreviations
Only to override
Changes by Jens Jährig jaehrig.j...@googlemail.com:
--
title: argparse disable abbreviation - argparse: disable abbreviation
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14910
___
Changes by Tshepang Lekhonkhobe tshep...@gmail.com:
--
nosy: +bethard, tshepang
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14910
___
___
Changes by Éric Araujo mer...@netwok.org:
--
versions: +Python 3.3 -Python 2.6, Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14910
___
37 matches
Mail list logo
