[issue14917] Make os.symlink on Win32 detect if target is directory

2012-06-24 Thread Larry Hastings
Larry Hastings la...@hastings.org added the comment: Note: I can't test this, as I only run Windows XP. But it compiles cleanly on Windows, and on Linux it compiles and passes the test suite fine. -- ___ Python tracker rep...@bugs.python.org

[issue14917] Make os.symlink on Win32 detect if target is directory

2012-06-24 Thread Larry Hastings
Larry Hastings la...@hastings.org added the comment: Martin: does this sound good or bad? -- nosy: +loewis ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14917 ___

[issue14917] Make os.symlink on Win32 detect if target is directory

2012-06-24 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: Uh. This was *removed* in a7406565ef1c :) See issue13772. -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14917 ___

[issue14917] Make os.symlink on Win32 detect if target is directory

2012-06-24 Thread Larry Hastings
Larry Hastings la...@hastings.org added the comment: Well then! Let's close this before the adults notice. -- resolution: - wont fix stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org

[issue14917] Make os.symlink on Win32 detect if target is directory

2012-06-23 Thread Larry Hastings
Larry Hastings la...@hastings.org added the comment: Patch attached. Implementation now uses GetFileAttributes (A or W) to determine whether or not src is a directory. Fixed docstring, docs, and updated Misc/NEWS. -- assignee: - larry keywords: +patch nosy: +mhammond stage: needs

[issue14917] Make os.symlink on Win32 detect if target is directory

2012-05-25 Thread Larry Hastings
New submission from Larry Hastings la...@hastings.org: The prototype for os.symlink on Windows adds a target_is_directory flag, which indicates whether or not the destination is a directory. Surely we could detect that and pass in the correct value ourselves? A quick GetFileAttributes() call