[issue14928] Fix importlib bootstrapping issues

Antoine Pitrou added the comment: Should be ok now. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue14928] Fix importlib bootstrapping issues

Roundup Robot added the comment: New changeset c3616595dada by Antoine Pitrou in branch 'default': Issue #14928: Fix importlib bootstrap issues by using a custom executable (Modules/_freeze_importlib) to build Python/importlib.h. http://hg.python.org/cpython/rev/c3616595dada -- nosy: +

[issue14928] Fix importlib bootstrapping issues

Georg Brandl added the comment: Is this ready to go in before beta1? -- nosy: +georg.brandl ___ Python tracker ___ ___ Python-bugs-li

[issue14928] Fix importlib bootstrapping issues

Antoine Pitrou added the comment: New patch incorporating Martin's and Nick's suggestions. -- Added file: http://bugs.python.org/file26039/cfreeze2.patch ___ Python tracker ___

[issue14928] Fix importlib bootstrapping issues

Martin v. Löwis added the comment: > Yes indeed. That's not deliberate, but because of how Makefile > dependencies are specified (importlib.h needs the _freeze_importlib > executable to be rebuilt, but it should really depend on the > _freeze_importlib.c timestamp). Do you have an idea to avoid

[issue14928] Fix importlib bootstrapping issues

Antoine Pitrou added the comment: > IIUC, this patch will cause importlib.h to always be built when > building from source, since _freeze_importlib will be built. Yes indeed. That's not deliberate, but because of how Makefile dependencies are specified (importlib.h needs the _freeze_importlib e

[issue14928] Fix importlib bootstrapping issues

Martin v. Löwis added the comment: IIUC, this patch will cause importlib.h to always be built when building from source, since _freeze_importlib will be built. Is it then the plan to drop importlib.h from version control? If so, the Windows build process would need to be adjusted as well (wit

[issue14928] Fix importlib bootstrapping issues

Nick Coghlan added the comment: Looks like a solid improvement to me. One minor naming quibble is that "FROZENLESS_LIBRARY_OBJS" hurts my brain - would you mind switching it to something like "LIBRARY_OBJS_OMIT_FROZEN"? -- ___ Python tracker

[issue14928] Fix importlib bootstrapping issues

Meador Inge added the comment: Nice patch Antoine! The method of partitioning the object sets into frozen and non-frozen is nice. > The proposed "-X" or BOOTSTRAP_PY approaches would be difficult, since there > doesn't appear to be an easy way to generate a given file (the Python > interpreter

[issue14928] Fix importlib bootstrapping issues

Antoine Pitrou added the comment: Here is a patch for the "separate C executable" approach. There are a couple of small complications in order to avoid any circular dependency (either at the Makefile level, or at the _frozen_importlib / Py_Initialize level). The proposed "-X" or BOOTSTRAP_PY

[issue14928] Fix importlib bootstrapping issues

Changes by Meador Inge : -- nosy: +meador.inge ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue14928] Fix importlib bootstrapping issues

Nick Coghlan added the comment: There are some additional challenges potentially posed by suggestions like http://bugs.python.org/issue10399, which would allow the compiler itself to use Python extensions. However, those could be overcome by requiring that the compiler support running with a

[issue14928] Fix importlib bootstrapping issues

Changes by Eric V. Smith : -- nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue14928] Fix importlib bootstrapping issues

Nick Coghlan added the comment: I like MvL's approach if we can make it work - then we can set up the importlib.h regeneration to automatically bootstrap itself from the source file and avoid having to add another binary to the build process. -- nosy: +ncoghlan __

[issue14928] Fix importlib bootstrapping issues

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue14928] Fix importlib bootstrapping issues

New submission from Antoine Pitrou : See http://mail.python.org/pipermail/python-dev/2012-May/119703.html Two competing proposals: - Benjamin: "Perhaps freeze_importlib.py could be rewritten in C, so importlib could be recompiled when the compiler changes?" - Martin: "Or we support bootstrappi