[issue15036] mailbox.mbox fails to pop two items in a row, flushing in between

Petri Lehtinen added the comment: Perfect, fixed. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue15036] mailbox.mbox fails to pop two items in a row, flushing in between

Roundup Robot added the comment: New changeset 8b38a81ba3bf by Petri Lehtinen in branch '2.7': Fix NEWS entry for #15036 http://hg.python.org/cpython/rev/8b38a81ba3bf New changeset 38e2a87c9051 by Petri Lehtinen in branch '3.2': Fix NEWS entry for #15036 http://hg.python.org/cpython/rev/38e2a87

[issue15036] mailbox.mbox fails to pop two items in a row, flushing in between

R. David Murray added the comment: "Mailbox no longer throws an error if a flush is done between operations when removing or changing multiple items in mbox, MMDF, or Babyl mailboxes." -- ___ Python tracker _

[issue15036] mailbox.mbox fails to pop two items in a row, flushing in between

Petri Lehtinen added the comment: Yes, this is what I tried to say. It's hard for me to find a good wording, so what would you suggest? I also noticed now that there's a typo in the commit messages. But those cannot be fixed anymore. -- ___ Python t

[issue15036] mailbox.mbox fails to pop two items in a row, flushing in between

R. David Murray added the comment: The news item isn't completely clear. It sounds like the mailbox is now automatically being flushed between pops, but what you really fixed is popping if the *application* does a flush between them, right? -- ___

[issue15036] mailbox.mbox fails to pop two items in a row, flushing in between

Changes by Petri Lehtinen : -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker ___ __

[issue15036] mailbox.mbox fails to pop two items in a row, flushing in between

Roundup Robot added the comment: New changeset 0add70dd3c43 by Petri Lehtinen in branch '2.7': #15036: Make a repeated changes and flushes work with single-file mailboxes http://hg.python.org/cpython/rev/0add70dd3c43 New changeset 714b8f91f3d4 by Petri Lehtinen in branch '3.2': #15036: Make a r

[issue15036] mailbox.mbox fails to pop two items in a row, flushing in between

Petri Lehtinen added the comment: As I suspected, all single-file mailboxes(mbox, MMDF, Babyl) have this issue. Attached a patch with tests. -- keywords: +patch Added file: http://bugs.python.org/file26017/issue15036.patch ___ Python tracker

[issue15036] mailbox.mbox fails to pop two items in a row, flushing in between

Petri Lehtinen added the comment: The fix seems to be very simple: diff --git a/Lib/mailbox.py b/Lib/mailbox.py index a677729..2be4c83 100644 --- a/Lib/mailbox.py +++ b/Lib/mailbox.py @@ -675,6 +675,7 @@ class _singlefileMailbox(Mailbox): new_file.write(buffer)

[issue15036] mailbox.mbox fails to pop two items in a row, flushing in between

Changes by R. David Murray : -- components: +email nosy: +barry, r.david.murray stage: -> needs patch type: -> behavior ___ Python tracker ___ _

[issue15036] mailbox.mbox fails to pop two items in a row, flushing in between

Petri Lehtinen added the comment: Actually, you don't even need to unlock() and lock() the mailbox before the second popitem() and flush(). -- ___ Python tracker ___ _

[issue15036] mailbox.mbox fails to pop two items in a row, flushing in between

New submission from Petri Lehtinen : test_mbox is an mbox mailbox with a few messages in it. >>> import mailbox >>> inbox = mailbox.mbox('test_mbox') >>> inbox.lock() >>> inbox.popitem() (0, ) >>> inbox.flush() >>> inbox.unlock() >>> inbox.lock() >>> inbox.popitem() (1, ) >>> inbox.flush() Trace