[issue15083] Rewrite ElementTree tests in a cleaner and safer way

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 2.7 ___ Python tracker

[issue15083] Rewrite ElementTree tests in a cleaner and safer way

Serhiy Storchaka added the comment: New changeset 68903b656d4e1011525a46cbd1338c6cbab83d6d by Serhiy Storchaka in branch '2.7': bpo-15083: Convert ElementTree doctests to unittests. (#906) https://github.com/python/cpython/commit/68903b656d4e1011525a46cbd1338c6cbab83d6d --

[issue15083] Rewrite ElementTree tests in a cleaner and safer way

Serhiy Storchaka added the comment: It is hard to backport bugfixes to 2.7 since tests are too different. Due to this I backported some bugfixes without tests and omitted backporting other bugfixes. PR 906 converts doctests in 2.7 to unittests. This will help backporting bugfixes too much.

[issue15083] Rewrite ElementTree tests in a cleaner and safer way

Changes by Serhiy Storchaka : -- pull_requests: +806 ___ Python tracker ___ ___

[issue15083] Rewrite ElementTree tests in a cleaner and safer way

Eli Bendersky added the comment: Great, thanks. Now looking forward to the patch getting rid of the module-level globals. One idea is explicitly pass the module into each testing class. The classes should not rely on anything global in this respect. --

[issue15083] Rewrite ElementTree tests in a cleaner and safer way

Ezio Melotti added the comment: The next logical step is to make all test classes in test_xml_etree accept the ET module in some way and store it, using it to get classes function. I.e. no more global ET and pyET at all. The idiom suggested by PEP 399 has the two modules (cmod and pymod)

[issue15083] Rewrite ElementTree tests in a cleaner and safer way

Eli Bendersky added the comment: On Tue, Feb 26, 2013 at 8:08 PM, Ezio Melotti rep...@bugs.python.orgwrote: Ezio Melotti added the comment: The next logical step is to make all test classes in test_xml_etree accept the ET module in some way and store it, using it to get classes

[issue15083] Rewrite ElementTree tests in a cleaner and safer way

Ezio Melotti added the comment: I'm just not sure how the globals help It doesn't, but if it works fine there's probably no reason to complicate (if it's complicated at all) things to change this. even when I just want to run the pure Python code, the C module gets imported. Why should it

[issue15083] Rewrite ElementTree tests in a cleaner and safer way

Serhiy Storchaka added the comment: Here is a patch which converts all etree doctests to unittests. -- keywords: +patch nosy: +serhiy.storchaka stage: needs patch - patch review Added file: http://bugs.python.org/file29230/test_xml_etree.patch ___

[issue15083] Rewrite ElementTree tests in a cleaner and safer way

Eli Bendersky added the comment: Serhiy, thanks for working on this! I didn't read the whole patch yet - will tinker with it a bit more when applying. Did you prepare the patch vs. 3.3 or default? The two are still synced and I'd be happy to apply it to both branches. Now, the real reason I

[issue15083] Rewrite ElementTree tests in a cleaner and safer way

Serhiy Storchaka added the comment: This patch is for default branch. It applied to 3.3 too. The next logical step is to make all test classes in test_xml_etree accept the ET module in some way and store it, using it to get classes function. I.e. no more global ET and pyET at all. Would

[issue15083] Rewrite ElementTree tests in a cleaner and safer way

Eli Bendersky added the comment: No problems. You can go ahead and commit this patch to 3.3 and default, then. I will review it post-commit, since I wanted to tweak some things around anyway. -- ___ Python tracker rep...@bugs.python.org

[issue15083] Rewrite ElementTree tests in a cleaner and safer way

Changes by Eli Bendersky eli...@gmail.com: -- versions: +Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15083 ___ ___ Python-bugs-list

[issue15083] Rewrite ElementTree tests in a cleaner and safer way

Roundup Robot added the comment: New changeset af570205b978 by Serhiy Storchaka in branch '3.3': Issue #15083: Convert ElementTree doctests to unittests. http://hg.python.org/cpython/rev/af570205b978 New changeset 5eefc85b8be8 by Serhiy Storchaka in branch 'default': Issue #15083: Convert

[issue15083] Rewrite ElementTree tests in a cleaner and safer way

Eli Bendersky added the comment: It should be noted that the doctests complicate things considerably, and should be rewritten to be unittest, which are easier to manipulate in terms of modules used. -- ___ Python tracker rep...@bugs.python.org

[issue15083] Rewrite ElementTree tests in a cleaner and safer way

Roundup Robot added the comment: New changeset f9d1d120c19e by Eli Bendersky in branch '3.3': Issues #15083 and #16992: port find.* method tests to unittest http://hg.python.org/cpython/rev/f9d1d120c19e New changeset 18b16104166c by Eli Bendersky in branch 'default': Issues #15083 and #16992:

[issue15083] Rewrite ElementTree tests in a cleaner and safer way

Changes by Andrew Svetlov andrew.svet...@gmail.com: -- nosy: +asvetlov ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15083 ___ ___

[issue15083] Rewrite ElementTree tests in a cleaner and safer way

Changes by Daniel Shahaf pyt...@danielsh.fastmail.net: -- nosy: +danielsh ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15083 ___ ___

[issue15083] Rewrite ElementTree tests in a cleaner and safer way

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15083 ___

[issue15083] Rewrite ElementTree tests in a cleaner and safer way

Changes by Eli Bendersky eli...@gmail.com: -- versions: -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15083 ___ ___ Python-bugs-list

[issue15083] Rewrite ElementTree tests in a cleaner and safer way

Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15083 ___ ___

[issue15083] Rewrite ElementTree tests in a cleaner and safer way

Changes by Tshepang Lekhonkhobe tshep...@gmail.com: -- nosy: +tshepang ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15083 ___ ___

[issue15083] Rewrite ElementTree tests in a cleaner and safer way

New submission from Eli Bendersky eli...@gmail.com: As #15075 demonstrated, the ET tests are sensitive to execution order because of the way they operate. Two sets of tests (one for the C module and one for the pure Python module) operate from the same test code, monkey-patching the imported