Antoine Pitrou pit...@free.fr added the comment:
What is the purpose of the comment at the end of Python/importlib.h?
The purpose is to include a NUL character in the source file so that Mercurial
treats this (generated) file as a binary file, and so that the diffs are
omitted in commit
Serhiy Storchaka storch...@gmail.com added the comment:
It looks as great disadvantage compared with Subversion.
There are several ways to solve this problem:
1. Python/freeze_importlib.py generates a raw binary file Python/importlib.dump
(just marshal dump) and this file is placed in the
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 7d86e207598f by Antoine Pitrou in branch 'default':
Issue #15103: remove the NUL character (serving as a Mercurial binary marker)
from Python/importlib.h.
http://hg.python.org/cpython/rev/7d86e207598f
--
Antoine Pitrou pit...@free.fr added the comment:
This should be fixed now.
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15103
Jesús Cea Avión j...@jcea.es added the comment:
As a general rule, generated files should not be included in the repository.
Recent mercurial versions include a --large parameter for hg add that
threat files as binary. In particular, precludes hg diff, that I guess it is
the point here.
Antoine Pitrou pit...@free.fr added the comment:
As a general rule, generated files should not be included in the
repository.
We already include generated files such as configure. This is either for
convenience or for bootstrap purposes.
Recent mercurial versions include a --large parameter
New submission from Antoine Pitrou pit...@free.fr:
The Solaris compiler chokes on the embedded NUL character. Perhaps we can find
another way to remove the importlib.h diffs from the notification e-mails
(simply hardcode the filename?).
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15103
___
___
Python-bugs-list mailing list
Justin Venus justin.ve...@gmail.com added the comment:
What is the purpose of the comment at the end of Python/importlib.h? If I
remove the comment that states binary marker for mercurial (something to that
effect anyhow) the code compiles and only the tests fail.
--
nosy:
