[issue15137] Cleaned source of `cmd` module

Changes by Éric Araujo : -- resolution: -> invalid stage: -> committed/rejected ___ Python tracker ___ ___ Python-bugs-list mailing

[issue15137] Cleaned source of `cmd` module

Éric Araujo added the comment: Just wanted to offer a comment on this: > Last point. Please use .diff or .patch for diff/patch files as that > extension works better for people Depending on OS and file association settings, yes. > and, I believe, hg. Mercurial does not care about file extension

[issue15137] Cleaned source of `cmd` module

Changes by Éric Araujo : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue15137] Cleaned source of `cmd` module

Terry J. Reedy added the comment: Do read PEP 8 Python style guide. http://python.org/dev/peps/pep-0008/ You violated the following: (Peeves) More than one space around an assignment (or other) operator to align it with another. Yes: x = 1 y = 2 long_variable = 3 No: x = 1 y

[issue15137] Cleaned source of `cmd` module

R. David Murray added the comment: Also as an FYI, triple double quote marks are our standard for docstrings. I don't believe we normally align assignments, but I don't know if that is specifically called out in PEP8. I haven't looked at the patch in detail, but in scanning it quickly, whil

[issue15137] Cleaned source of `cmd` module

R. David Murray added the comment: I appreciate the work and thought that went into this, but this is not normally the kind of change that we apply. Any change has a chance of introducing bugs (see, for example, issue 15109, where a seemingly innocuous change from % formatting to .format for

[issue15137] Cleaned source of `cmd` module

Zearin added the comment: Does `hg diff` produce different output than regular `diff`? If so, the patch created by regular `diff` is attached. (I basically did my work without using a local repo, and I have very little experience with patching. I basically just looked up how to create a pa

[issue15137] Cleaned source of `cmd` module

Amaury Forgeot d'Arc added the comment: The output of "hg diff" would be much appreciated, it's the only way for reviewers to realize the changes you made. -- nosy: +amaury.forgeotdarc ___ Python tracker

[issue15137] Cleaned source of `cmd` module

New submission from Zearin : Cleaned up the source of the Standard Library’s `cmd` module. Attempted to focus on readability by changing things like using booleans instead of 0/1, newer syntax for string formatting, lining up variable declarations (judgement call), and adding comments betwee