[issue1514] missing constants in socket module

2010-02-22 Thread A.M. Kuchling
A.M. Kuchling added the comment: The original problem has been fixed since 2007. Improving the #if condition doesn't seem very important to anyone, so I'll just close this bug. -- nosy: +akuchling resolution: -> fixed status: open -> closed ___ Py

[issue1514] missing constants in socket module

2007-11-30 Thread Skip Montanaro
Skip Montanaro added the comment: mal> Interesting. It appears as if r57142 caused this change. Skip> How do I get a diff of the change in r57142? Okay, I got that diff. The change was from my BeOS cleaning. While adding back in that ifdef certain restores the desired behavior, I think it

[issue1514] missing constants in socket module

2007-11-30 Thread Skip Montanaro
Skip Montanaro added the comment: mal> Interesting. It appears as if r57142 caused this change. How do I get a diff of the change in r57142? In particular, is it something I did? I was working on deleting BeOS support (and support for other minority platforms) awhile ago. I don't recall wheth

[issue1514] missing constants in socket module

2007-11-30 Thread Christian Heimes
Christian Heimes added the comment: Marc-Andre Lemburg wrote: > Marc-Andre Lemburg added the comment: > > Interesting. It appears as if r57142 caused this change. Good work, Marc-Andre! I've restored the old semantic in r57142. Christian __ Tracker <[EMAIL PROT

[issue1514] missing constants in socket module

2007-11-30 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Interesting. It appears as if r57142 caused this change. Before: # if !(defined(__BEOS__) || defined(__CYGWIN__) || (defined(PYOS_OS2) && defined(PYCC_VACPP))) After: # if defined(__CYGWIN__) || (defined(PYOS_OS2) && defined(PYCC_VACPP)) That change obvi

[issue1514] missing constants in socket module

2007-11-30 Thread Christian Heimes
Christian Heimes added the comment: On my system (Ubuntu 7.10, i386, Kernel 2.6.20) the _socket modules of Python 2.5 and trunk have the TCP_ constants. __ Tracker <[EMAIL PROTECTED]> __ __

[issue1514] missing constants in socket module

2007-11-30 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Doesn't this bug report also refer to Python 2.5 and 2.6 ? __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list m

[issue1514] missing constants in socket module

2007-11-30 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: If you think we need a better tool, that's a different story, but not an argument for cluttering up the socket module with a more or less complete list of C constants. It's much easier to maintain this outside the socket module in a separate, platform specif

[issue1514] missing constants in socket module

2007-11-30 Thread Martin v. Löwis
Martin v. Löwis added the comment: I disagree. h2py is much too unreliable, and should be phased out over time. __ Tracker <[EMAIL PROTECTED]> __ ___ Pyt

[issue1514] missing constants in socket module

2007-11-30 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: While the patch looks right (can't say for sure whether netinet/tcp.h is always available), I think the approach itself of adding these constants to the socket module is wrong. Instead of adding these constants to the socket module, they should go into a new

[issue1514] missing constants in socket module

2007-11-30 Thread Christian Heimes
Christian Heimes added the comment: I've added Lemburg, Löwis and Skip to the nosy list. svn ann shows their names frequently. -- nosy: +loewis, skip.montanaro __ Tracker <[EMAIL PROTECTED]> _

[issue1514] missing constants in socket module

2007-11-30 Thread Christian Heimes
Christian Heimes added the comment: On my Linux box (Ubuntu 7.10, i386, 2.6.22) the TCP_* constants are also missing. This patch solves the bug. Index: Modules/socketmodule.h === --- Modules/socketmodule.h (revision 59228) +++

[issue1514] missing constants in socket module

2007-11-28 Thread David Binger
New submission from David Binger: TCP_NODELAY and some constants are not present in the socket module. I think maybe "#include " should appear somewhere, perhaps at the top of socketmodule.c? (This is on OS X 10.5.1 with py3k revision 59215). -- components: Library (Lib), Macintosh mess