Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset ee01fd98b5b0 by Brett Cannon in branch 'default':
Issue #15242: Have PyImport_GetMagicTag() return a const char *
http://hg.python.org/cpython/rev/ee01fd98b5b0
--
nosy: +python-dev
Brett Cannon br...@python.org added the comment:
I went ahead and committed Eric's patch. Amaury, if you want to move the macros
to a header file I see no reason not to, but I also don't see a need so I
didn't want to spend the time doing it myself.
--
resolution: - fixed
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
It's not necessary. The fix looks good as is.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15242
___
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15242
___
Eric Snow ericsnowcurren...@gmail.com added the comment:
Here's a new patch that keeps things simpler, but still cleans up the concerns
about using sys.implementation.cache_tag in PyImport_GetMagicTag().
--
Added file: http://bugs.python.org/file26280/cache_tag_via_sys_var.diff
Changes by Eric Snow ericsnowcurren...@gmail.com:
Removed file: http://bugs.python.org/file26280/cache_tag_via_sys_var.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15242
___
Eric Snow ericsnowcurren...@gmail.com added the comment:
Patch updated to include a doc addition.
--
Added file: http://bugs.python.org/file26281/cache_tag_via_sys_var.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15242
Larry Hastings la...@hastings.org added the comment:
Sorry for the pedantry, but: I read the title of this bug as wanting these two
values to be the exact same pointer. If you're talking about putting a
constant string in a header file, you'll get an (identical) copy of that string
in every
Brett Cannon br...@python.org added the comment:
tl;dr: ==, not is
Shouldn't tl;dr go first, else it seems a little pointless since I already read
the whole thing. At which point the tl;dr is really just a summary of what I
just read, not a didn't read line. Just being pedantic. =)
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15242
___
New submission from Eric Snow ericsnowcurren...@gmail.com:
There was some concern with PyImport_GetMagicTag() extracting its value from
sys.implementation.cache_tag. One solution is to have the two use a common
underlying value. However, that's basically what was already in import.c and
I'd
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Can the #defines appear in pyconfig.h instead? I find it easier to discover
them this way, and will also simplify the implementation on Windows.
--
___
Python tracker rep...@bugs.python.org
Eric Snow ericsnowcurren...@gmail.com added the comment:
Can the #defines appear in pyconfig.h instead? I find it easier to
discover them this way, and will also simplify the implementation on
Windows.
Agreed. I'd like to pull them into Python/sysmodule.h, though. I'm also going
to drop
13 matches
Mail list logo